Skip to content

Prodcre 421 integration tests#227

Merged
jinhoonbang merged 38 commits into
mainfrom
PRODCRE-421-integration-tests
Aug 26, 2025
Merged

Prodcre 421 integration tests#227
jinhoonbang merged 38 commits into
mainfrom
PRODCRE-421-integration-tests

Conversation

@jinhoonbang

@jinhoonbang jinhoonbang commented Aug 19, 2025

Copy link
Copy Markdown
Contributor
  • implement HTTP trigger integration tests
  • test case 1: trigger workflow using workflowID
  • test case 2: trigger workflow using workflowName/Owner/Tag
  • test case 3: triggering workflow is deduplicated if repeating request
  • test case 4: time out when insufficient # of workflow nodes

jinhoonbang and others added 27 commits June 4, 2025 18:28
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jinhoonbang jinhoonbang requested review from Copilot and removed request for justinkaseman and yashnevatia August 19, 2025 17:34
@github-actions

Copy link
Copy Markdown

👋 jinhoonbang, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements HTTP trigger integration tests for workflow execution with three main test scenarios: triggering workflows using workflow ID, triggering using workflow name/owner/tag, and handling timeout scenarios with insufficient nodes.

Key changes:

  • Adds comprehensive HTTP trigger integration tests with different workflow selector methods
  • Refactors existing HTTP test infrastructure to support both action and trigger capabilities
  • Updates dependencies to include the new http_trigger module

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

File Description
integration_tests/http/http_trigger_test.go New integration test file implementing HTTP trigger tests with workflow ID and reference-based triggers
integration_tests/http/http_test.go Refactors package name and gateway configuration to support shared test infrastructure
integration_tests/go.mod Adds http_trigger dependency and updates chainlink module versions
http_trigger/trigger/connector_handler.go Updates workflow trigger logic to use execution ID instead of request ID

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread integration_tests/http/http_trigger_test.go Outdated
Comment thread integration_tests/http/http_trigger_test.go
Comment thread integration_tests/http/http_trigger_test.go Outdated
Comment thread integration_tests/http/http_trigger_test.go
Comment thread integration_tests/http/http_trigger_test.go
jinhoonbang and others added 4 commits August 20, 2025 02:53
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jinhoonbang jinhoonbang requested a review from MStreet3 August 25, 2025 07:47
@jinhoonbang jinhoonbang added this pull request to the merge queue Aug 26, 2025
Merged via the queue into main with commit b98e2b5 Aug 26, 2025
20 checks passed
@jinhoonbang jinhoonbang deleted the PRODCRE-421-integration-tests branch August 26, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants