remove ineffectual replaces from go.mod files#24
Merged
Merged
Conversation
jmank88
commented
Oct 2, 2024
| sigs.k8s.io/yaml v1.4.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/smartcontractkit/capabilities => .. |
Contributor
Author
There was a problem hiding this comment.
This is not currently a module.
jmank88
commented
Oct 2, 2024
Comment on lines
-16
to
-23
| // until merged upstream: https://github.com/hashicorp/go-plugin/pull/257 | ||
| github.com/hashicorp/go-plugin => github.com/smartcontractkit/go-plugin v0.0.0-20240208201424-b3b91517de16 | ||
|
|
||
| // until merged upstream: https://github.com/mitchellh/mapstructure/pull/343 | ||
| github.com/mitchellh/mapstructure v1.5.0 => github.com/nolag/mapstructure v1.5.2-0.20240625151721-90ea83a3f479 | ||
|
|
||
| // until merged upstream: https://github.com/mwitkow/grpc-proxy/pull/69 | ||
| github.com/mwitkow/grpc-proxy => github.com/smartcontractkit/grpc-proxy v0.0.0-20230731113816-f1be6620749f |
Contributor
Author
There was a problem hiding this comment.
These are no longer necessary with recent versions of common.
@nolag Do we need to bump common for the mapstructure changes?
Contributor
There was a problem hiding this comment.
I always bump common when I remove replace. I think it's already on a new enough one, but better safe than sorry :).
Contributor
There was a problem hiding this comment.
Approved, I remember that I updated common recently so mapstructure is good to go away as an override
jmank88
commented
Oct 2, 2024
| // until merged upstream: https://github.com/mwitkow/grpc-proxy/pull/69 | ||
| github.com/mwitkow/grpc-proxy => github.com/smartcontractkit/grpc-proxy v0.0.0-20230731113816-f1be6620749f | ||
|
|
||
| github.com/smartcontractkit/capabilities/libs/types => ../../libs/types |
Contributor
Author
There was a problem hiding this comment.
This path had an extra .., but the module is unused anyways.
nolag
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these fixes in place,
gomodscan be used again, e.g.gomods tidyfrom the root.