Add LLM reporter + coverage and lint reports#33
Merged
Conversation
chudilka1
force-pushed
the
chore/CAPPL-124-Audit-CI
branch
30 times, most recently
from
56c5a56 to
9449db8
Compare
chudilka1
force-pushed
the
chore/CAPPL-124-Audit-CI
branch
4 times, most recently
from
f0b59bb to
d85b5f7
Compare
chudilka1
force-pushed
the
chore/CAPPL-124-Audit-CI
branch
from
d85b5f7 to
dff3f8f
Compare
agparadiso
approved these changes
Oct 22, 2024
DeividasK
reviewed
Oct 22, 2024
| sonarqube: | ||
| name: SonarQube Scan | ||
| needs: [test, lint] | ||
| if: ${{ always() && github.actor != 'dependabot[bot]' }} |
Contributor
There was a problem hiding this comment.
- Don't you want to skip it if no
testandlinttasks were performed? - We don't have dependabot so we don't need a condition for it?
Contributor
Author
There was a problem hiding this comment.
- It runs its analysis, and if the test and lint are skipped or failed, SonarQube's Quality Gate will serve as the other sign to pay attention to.
- Removed dependabot.
Contributor
There was a problem hiding this comment.
If tests and lints are skipped, we don't want to run the scan, right? IIUC, we only want to run it if the tasks pass or fail.
Contributor
Author
There was a problem hiding this comment.
SonarQube has its scanning engine, which is helpful independently of other workflow results. An engineer might want to collect as much information about all the fails in one run instead of failing fast and then rerunning the workflows each time after a fix to determine whether Sonar also throws any errors. IMHO, it is more flexible and cost-efficient.
Contributor
There was a problem hiding this comment.
If lint and test are skipped, there are no affected projects (for example only the README.md file was changed), which means there's no point in running the SonarQube.
DeividasK
reviewed
Oct 22, 2024
DeividasK
reviewed
Oct 22, 2024
DeividasK
reviewed
Oct 22, 2024
DeividasK
reviewed
Oct 22, 2024
DeividasK
reviewed
Oct 22, 2024
chudilka1
force-pushed
the
chore/CAPPL-124-Audit-CI
branch
from
dff3f8f to
78fc5f0
Compare
DeividasK
approved these changes
Oct 23, 2024
cedric-cordenier
pushed a commit
that referenced
this pull request
Nov 19, 2024
* Add test and linting reports generation * Add LLM Action Error Reporter workflow * Add Golangci Lint report generation * Add Go test report generation and uploading * Add golangci lint report generation and uploading * Integrate SonarQube * Fix: rename libs/cll -> libs/cli in accordance to go.mod module name * Update linter command: remove report generation from local runs * Add sonar to nx sharedGlobals to run test when properties are changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.