Add cron trigger capability#7
Merged
Merged
Conversation
DeividasK
reviewed
Aug 26, 2024
|
|
||
| const cronTriggerID = "cron-trigger@1.0.0" | ||
|
|
||
| // TODO pending capabilities configuration implementation - this should be configurable with a sensible default |
Contributor
There was a problem hiding this comment.
This has already been implemented, hasn't it?
DeividasK
reviewed
Aug 26, 2024
DeividasK
reviewed
Aug 26, 2024
DeividasK
reviewed
Aug 26, 2024
DeividasK
reviewed
Aug 26, 2024
| // Time that cron trigger's task execution occurred (RFC3339Nano formatted) | ||
| ActualExecutionTime string | ||
| // Time that cron trigger's task execution had been scheduled to occur (RFC3339Nano formatted) | ||
| ScheduledExecutionTime string |
Contributor
There was a problem hiding this comment.
@justinkaseman One idea to improve this is to build support for time objects in the values library. I think this makes a lot of sense and would be useful for other use cases; atm we work around this via this trick, but it's a bit hacky.
Contributor
Author
There was a problem hiding this comment.
Good idea. I'll make a ticket for this.
cedric-cordenier
approved these changes
Aug 28, 2024
DeividasK
approved these changes
Aug 29, 2024
cedric-cordenier
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR moves over the chainlink-common PR: smartcontractkit/chainlink-common#715
It depends on Trigger API changes.
Draft PR until they are merged.