This repository was archived by the owner on Mar 14, 2025. It is now read-only.
[BCI-3988] - FilteredLogs receive []Expression instead of whole KeyFilter #1403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Farber98
force-pushed
the
BCI-3988-remove-keyfilter-from-filteredlogs
branch
from
8d8d782 to
bbeaa07
Compare
Signed-off-by: Farber98 <juan.farber@smartcontract.com>
Farber98
force-pushed
the
BCI-3988-remove-keyfilter-from-filteredlogs
branch
from
bbeaa07 to
4c71b24
Compare
|
Contributor
mateusz-sekara
left a comment
mateusz-sekara
left a comment
There was a problem hiding this comment.
@Farber98 we keep merging chainlink repository every 2-3 weeks so if you merge that in the upstream we will get that eventually. No need to create a PR in ccip repo unless it's super critical for CCIP to have
mateusz-sekara
deleted the
BCI-3988-remove-keyfilter-from-filteredlogs
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description:
Log poller Filtered logs have no use for Key, which makes the method confusing when used outside of CR
This PR:
FilteredLogsmethod so it receives[]query.Expressioninstead of wholequery.KeyFilteras param.Ticket:
Merged With: