offchain - rpc batch caller lib + use it for offramp rpc calls#233
offchain - rpc batch caller lib + use it for offramp rpc calls#233dimkouv merged 18 commits intoccip-developfrom
Conversation
core/services/ocr2/plugins/ccip/internal/ccipdata/offramp_v1_0_0.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/ccip/internal/ccipdata/offramp_v1_0_0.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/ccip/internal/ccipdata/offramp_v1_0_0.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/ccip/internal/ccipdata/offramp_reader.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/ccip/internal/ccipdata/offramp_v1_0_0.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/ccip/internal/ccipdata/offramp_v1_0_0.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks good to me. However, as a follow-up, I think it's worth investigating using the same value as the one provided in the toml file smartcontractkit/chainlink#9119
This way, maybe we could avoid backoff in the code because NOPs, in case of any issues, can lower the batch RPC limit themselves. @connorwstein wdyt? Worth asking core team about they opinion on this approach anyway.
core/services/ocr2/plugins/ccip/internal/ccipdata/offramp_reader_v1_0_0_unit_test.go
Show resolved
Hide resolved
Yeah I think at least standardizing on defaults per chain across all services makes sense. In that case I think the parameter would need to move out of Gas estimation to a more general place though. I think backoff code is straightforward enough prob worth to keep for its graceful degradation. |
Implemented the following interface
And created a new
offRampReadermethod that utilizes it.Limit of rpc batch calls is set to:
And with back-off policy four retries are going to be made each with the following batch sizes: