This repository was archived by the owner on Mar 14, 2025. It is now read-only.
CCIP-1311 Reporting number of results returned from Contract Readers#288
Merged
mateusz-sekara merged 1 commit intoccip-developfrom Nov 17, 2023
Merged
Conversation
mateusz-sekara
changed the title
connorwstein
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
LogPoller metrics can't contain information about the plugin used to execute specific queries. Some of the
Readermethods are proxies for LogPoller, so tracking the number of records returned here could help us identify which part of the code hits LogPoller.Solution
Combine all existing metrics with latencies into a single one (it would be simpler). And introduce another one to track the number of records returned. This is very similar to what we already have for LP.