CCIP-1306 Using proper query for fetching single CommitReport from the LP

[mateusz-sekara]

Motivation

The current approach to fetching CommitReport based on seqNr is suboptimal. We can have query with better filters that pick exactly one report that we need instead of fetching all Commit Reports greater or equal passed sequence number. Under higher load it becomes a bottleneck

Solution

Use a dedicated query LogsDataWordBetween that applies lower and upper bound filters in the SQL query

[dimkouv]

love this!
added some nits

[connorwstein]

we should be erroring if len(logs) > 1 to comply with the interface comment

[mateusz-sekara]

I added defensive check + log without returning an error. If we get more than one it's probably a scenario which will be hard to recover from, I assume it might be some glitch/error in LP - for instance, it persisted the same Log twice or sth. Let's be defensive here, but also not break processing. Therefore I added log and returned always at most 1 element slice

[mateusz-sekara]

@dimkouv No big difference ;) 1-2 ms on avg, let's wait with adding limit1 until we have some DSL to do that

Using LIMIT 1

Benchmark_LogsDataWordBetween
Benchmark_LogsDataWordBetween-12    	      42	  26292686 ns/op
Benchmark_LogsDataWordBetween-12    	      40	  26545705 ns/op
Benchmark_LogsDataWordBetween-12    	      42	  25068981 ns/op
Benchmark_LogsDataWordBetween-12    	      42	  24866132 ns/op
Benchmark_LogsDataWordBetween-12    	      43	  25001792 ns/op
Benchmark_LogsDataWordBetween-12    	      43	  25912275 ns/op
Benchmark_LogsDataWordBetween-12    	      43	  24767023 ns/op
Benchmark_LogsDataWordBetween-12    	      42	  26012244 ns/op
Benchmark_LogsDataWordBetween-12    	      48	  25809934 ns/op
Benchmark_LogsDataWordBetween-12    	      42	  24808771 ns/op
PASS

Without LIMIT

Benchmark_LogsDataWordBetween
Benchmark_LogsDataWordBetween-12    	      42	  26762404 ns/op
Benchmark_LogsDataWordBetween-12    	      43	  27254803 ns/op
Benchmark_LogsDataWordBetween-12    	      39	  28243682 ns/op
Benchmark_LogsDataWordBetween-12    	      43	  27615336 ns/op
Benchmark_LogsDataWordBetween-12    	      39	  27010718 ns/op
Benchmark_LogsDataWordBetween-12    	      43	  26643946 ns/op
Benchmark_LogsDataWordBetween-12    	      44	  26516652 ns/op
Benchmark_LogsDataWordBetween-12    	      39	  34758611 ns/op
Benchmark_LogsDataWordBetween-12    	      40	  25562183 ns/op
Benchmark_LogsDataWordBetween-12    	      42	  26939871 ns/op
PASS