This repository was archived by the owner on Mar 14, 2025. It is now read-only.
Don't require finality when fetching CCIPSendRequested in the execution phase#347
Merged
mateusz-sekara merged 4 commits intoccip-developfrom Dec 4, 2023
Merged
Don't require finality when fetching CCIPSendRequested in the execution phase#347mateusz-sekara merged 4 commits intoccip-developfrom
mateusz-sekara merged 4 commits intoccip-developfrom
Conversation
mateusz-sekara
force-pushed
the
exec-finality
branch
from
eb5af3c to
64f9ea7
Compare
mateusz-sekara
changed the title
mateusz-sekara
changed the title
connorwstein
approved these changes
Dec 4, 2023
mateusz-sekara
added a commit
that referenced
this pull request
Dec 4, 2023
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We don't need to verify finality when executing messages. We rely on the fact that CommitReport was properly transmitted on-chain, and during the execution phase, nodes don't have to double-check that.
This is a tiny performance boost because nodes will reach consensus faster. This also reduces the number of error logs when nodes see different chain finality and can't fetch the logs used to build the Commit Report.
Commit Plugin remains unchanged and still heavily rely only on finalized logs