This repository was archived by the owner on Mar 14, 2025. It is now read-only.
Merged
Conversation
winder
force-pushed
the
will/ccip-288
branch
from
32e8f38 to
70a9639
Compare
winder
commented
Dec 12, 2023
| s := time.Now() | ||
| r.lggr.Infow("start replaying src chain", "fromBlock", r.srcStartBlock) | ||
| srcReplayErr := r.src.Replay(ctx, r.srcStartBlock) | ||
| srcReplayErr := r.src.Replay(ctx, int64(r.srcStartBlock)) |
Contributor
Author
There was a problem hiding this comment.
Replay is used by other plugins, so it would be much more involved to propagate the type change further than this point.
winder
force-pushed
the
will/ccip-288
branch
4 times, most recently
from
6897ebd to
0ebe7d9
Compare
RensR
changed the title
connorwstein
approved these changes
Dec 13, 2023
winder
force-pushed
the
will/ccip-288
branch
from
d750294 to
6ed14ea
Compare
mateusz-sekara
approved these changes
Dec 14, 2023
winder
force-pushed
the
will/ccip-288
branch
from
6ed14ea to
8c6d967
Compare
jasonmci
pushed a commit
that referenced
this pull request
Dec 15, 2023
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Validate CCIP plugin configuration prior to loading the plugin when possible so that we can fail fast rather than attempting to start with bad configuration.
Solution
Add handling to existing
validateSpecfunction.