This repository was archived by the owner on Mar 14, 2025. It is now read-only.
Merged
Conversation
connorwstein
commented
Dec 14, 2023
| DestChainName: "SimulatedDest", | ||
| TokenPricesUSDPipeline: tokenPricesUSDPipeline, | ||
| DestStartBlock: uint64(configBlock), | ||
| USDCAttestationAPI: "http://blah.com", |
Collaborator
Author
There was a problem hiding this comment.
Enables coverage in Test_CLOSpecApprovalFlow
connorwstein
commented
Dec 14, 2023
| ) | ||
|
|
||
| // TODO pass context? | ||
| func jobSpecToExecPluginConfig(lggr logger.Logger, jb job.Job, chainSet evm.LegacyChainContainer, qopts ...pg.QOpt) (*ExecutionPluginStaticConfig, *BackfillArgs, error) { |
mateusz-sekara
approved these changes
Dec 15, 2023
mateusz-sekara
pushed a commit
that referenced
this pull request
Dec 15, 2023
makramkd
pushed a commit
that referenced
this pull request
Dec 18, 2023
merge core develop -> ccip-develop fix conflicts, build use openzeppelin-solidity v4.8.3 add ERC165Checker.sol to the vendor, wasn't there before add missing file update shared snapshot update gethwrappers add ERC165.sol to fix metatx compile update generated files update modgraph fix one config test fix some config tests fix config again more config test fixes bump mockery version in contracts makefile go.mod updates more updates remove integration-tests dependencies USDC filter fix (#383) fix integration-tests go mod more fixes fix lint errors fix TestSecrets_Validate fix TestResolver_ConfigV2 fix TestIntegration_CCIP try using crypto/rand remove build-publish-pr.yml skip metatx test
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
merge core develop -> ccip-develop fix conflicts, build use openzeppelin-solidity v4.8.3 add ERC165Checker.sol to the vendor, wasn't there before add missing file update shared snapshot update gethwrappers add ERC165.sol to fix metatx compile update generated files update modgraph fix one config test fix some config tests fix config again more config test fixes bump mockery version in contracts makefile go.mod updates more updates remove integration-tests dependencies USDC filter fix (#383) fix integration-tests go mod more fixes fix lint errors fix TestSecrets_Validate fix TestResolver_ConfigV2 fix TestIntegration_CCIP try using crypto/rand remove build-publish-pr.yml skip metatx test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Token data readers can also register filters (eg USDC). They need to be registered explicitly in the same tx for CLO to work properly.
Solution
Follow registration paradigm for USDC and ensure CLO integration test covers it.