Skip to content

chore(integration-tests): bump CTF to fix Aptos cwd tar race#436

Merged
Fletch153 merged 1 commit intodevelopfrom
fix-aptos-ctf-cwd-tar-race
Apr 15, 2026
Merged

chore(integration-tests): bump CTF to fix Aptos cwd tar race#436
Fletch153 merged 1 commit intodevelopfrom
fix-aptos-ctf-cwd-tar-race

Conversation

@Fletch153
Copy link
Copy Markdown
Contributor

@Fletch153 Fletch153 commented Apr 14, 2026

Summary

Bumps github.com/smartcontractkit/chainlink-testing-framework/framework in integration-tests/go.mod to v0.15.16 to pull in the upstream fix for an archive/tar: write too long flake in the Aptos CTF container-start path.

Upstream PR: smartcontractkit/chainlink-testing-framework#2519 (merged as v0.15.16).

Root Cause

chainlink-deployments-framework/chain/aptos/provider/ctf_provider.go:160 builds a blockchain.Input{Type: TypeAptos, ...} with no ContractsDir. CTF's newAptos unconditionally called filepath.Abs(in.ContractsDir) — Go stdlib resolves filepath.Abs("") to the process cwd. That path was attached as a testcontainers.ContainerFile, tarring the host test working directory. Files in that dir being written concurrently (logs, db dumps) trip archive/tar.ErrWriteTooLong between os.Stat (header size) and io.Copy (body).

Same bug shape as the Sui flake; fix is symmetric.

Fix

Module bump only — no source changes. Pins framework to v0.15.16 (stable tag), which gates the Files: entry on in.ContractsDir != "" in both sui.go and aptos.go.

Safety

  • Callers passing a non-empty ContractsDir: identical behaviour.
  • Callers passing empty (including this repo's integration-tests/ccip/ccip_deployment_test.go): req.Files now nil. testcontainers-go's copy-to-container hook iterates range files — zero iterations on nil, no-op.

Test plan

  • go get + go mod tidy clean
  • CI green — 19 checks pass, 1 skipped, 0 failing

Pulls in smartcontractkit/chainlink-testing-framework#2519 — the
Sui/Aptos CTF provider cwd tar-race fix. The Aptos provider in
chainlink-deployments-framework builds blockchain.Input with no
ContractsDir, causing upstream newAptos to filepath.Abs("") = cwd
and tar-stream the live test working directory. Growing log files
trip archive/tar: write too long intermittently.

Module bump only — no source changes.
@Fletch153 Fletch153 force-pushed the fix-aptos-ctf-cwd-tar-race branch from a1bb0dd to 20382fa Compare April 14, 2026 18:55
@Fletch153 Fletch153 marked this pull request as ready for review April 14, 2026 20:14
@Fletch153 Fletch153 requested review from a team as code owners April 14, 2026 20:14
@Fletch153 Fletch153 requested review from archseer and ilija42 April 15, 2026 15:32
@Fletch153 Fletch153 merged commit 5f17ad9 into develop Apr 15, 2026
21 checks passed
@Fletch153 Fletch153 deleted the fix-aptos-ctf-cwd-tar-race branch April 15, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants