CCIP-6146 Add chain selector param to ftf hooks #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xsuryansh
force-pushed
the
CCTP-6146-chainselector-param-ftf-hooks
branch
from
f46d9fb to
db77807
Compare
# Conflicts: # chains/evm/.gas-snapshot # chains/evm/gobindings/generated/latest/fast_transfer_token_pool/fast_transfer_token_pool.go # chains/evm/gobindings/generation/generated-wrapper-dependency-versions-do-not-edit.txt
|
RensR
reviewed
Jul 2, 2025
| // @inheritdoc CCIPReceiver | ||
| function _ccipReceive( | ||
| Client.Any2EVMMessage memory message | ||
| ) internal virtual override onlyRouter { |
Collaborator
There was a problem hiding this comment.
If you're making changes like these please provide context. This now looks like major security issue.
Member
Author
There was a problem hiding this comment.
The onlyRouter exist in ccipRouter public function, it was my mistake that I added it in the internal function as well
Member
Author
There was a problem hiding this comment.
Added the reason behind this change to the PR description
RensR
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onlyRouterfrom_ccipReceivesince it is redundant with the same check in public function ofCCIPReceiverabstract contract