Ccip-6729 config check of offRamp and CCIPHome config digest before adding messages to inflight cache #1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnieeG
requested review from
0xAustinWang,
KodeyThomas,
asoliman92,
b-gopalswami,
makramkd,
mateusz-sekara and
winder
|
👋 AnieeG, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
winder
reviewed
Sep 11, 2025
winder
reviewed
Sep 11, 2025
execute/observation.go
Outdated
| // If the previous outcome was the filter state, and reports were built, mark the messages as inflight. | ||
| if previousOutcome.State == exectypes.Filter { | ||
| if err := p.checkConfigDigest(); err != nil { | ||
| return types.Observation{}, fmt.Errorf("unable to build inflight cache: %w", err) |
Contributor
There was a problem hiding this comment.
Suggested change
| return types.Observation{}, fmt.Errorf("unable to build inflight cache: %w", err) | |
| return types.Observation{}, fmt.Errorf("skipping observation: %w", err) |
Contributor
There was a problem hiding this comment.
Could you also log an error here? It's sometimes difficult to find logs when we're no longer in the plugin layer.
winder
reviewed
Sep 11, 2025
execute/observation.go
Outdated
Comment on lines
550
to
552
| p.lggr.Warnw("my config digest doesn't match offramp's config digest, not starting", | ||
| "myConfigDigest", p.reportingCfg.ConfigDigest, | ||
| "offRampConfigDigest", hex.EncodeToString(offRampConfigDigest[:]), |
Contributor
There was a problem hiding this comment.
Suggested change
| p.lggr.Warnw("my config digest doesn't match offramp's config digest, not starting", | |
| "myConfigDigest", p.reportingCfg.ConfigDigest, | |
| "offRampConfigDigest", hex.EncodeToString(offRampConfigDigest[:]), | |
| p.lggr.Warnw("home chain config digest doesn't match offramp's config digest", | |
| "homeChainConfigDigest", p.reportingCfg.ConfigDigest, | |
| "offRampConfigDigest", hex.EncodeToString(offRampConfigDigest[:]), |
|
winder
approved these changes
Sep 11, 2025
0xAustinWang
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.