fix: resolve refs for update MCMS config changeset#2011
Merged
chris-de-leon-cll merged 1 commit intomainfrom Apr 27, 2026
Merged
fix: resolve refs for update MCMS config changeset#2011chris-de-leon-cll merged 1 commit intomainfrom
chris-de-leon-cll merged 1 commit intomainfrom
Conversation
|
chris-de-leon-cll
requested review from
AmrMohamedRezk,
KodeyThomas,
agusaldasoro,
asoliman92,
carte7000,
tt-cll and
winder
tt-cll
approved these changes
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes UpdateMCMSConfig so that contract refs are resolved to full refs and actually passed into the per-chain sequence input, ensuring downstream adapters receive resolved addresses (instead of needing workarounds).
Changes:
- Write resolved
MCMContractsrefs back onto the per-chain config before executing the update sequence. - Update the EVM adapter test to use partial refs (type/qualifier/version only) to validate the resolution logic.
- Correct the test’s contract type lookups for bypasser/proposer refs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
deployment/deploy/mcms.go |
Ensures resolved MCMS contract refs are propagated into the sequence input. |
chains/evm/deployment/v1_0_0/adapters/deployer_test.go |
Strengthens coverage by passing partial refs and fixing the bypasser/proposer ref types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AnieeG
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
UpdateMCMSConfigchangeset has code that resolves refs, but it never writes it back to the sequence input. As a result, all downstream adapter implementations get the unresolved refs. This fix ensures that the resolved refs get properly passed down, so that no extra workarounds are needed in CLD. The existing test cases did not catch this because they always use fully resolved refs (e.g.datastore_utils.FindAndFormatRef).