Skip to content

Conversation

@jinhoonbang
Copy link
Contributor

  • augment OutboundHTTPResponse with IsExternalEndpointError and ExternalEndpointLatency
  • add CacheAgeLimit to cresettings

@jinhoonbang jinhoonbang requested a review from a team as a code owner September 3, 2025 15:22
@jinhoonbang jinhoonbang requested a review from Copilot September 3, 2025 15:22
@github-actions
Copy link

github-actions bot commented Sep 3, 2025

👋 jinhoonbang, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

apidiff results - no incompatible changes detected ✅

Module: github-com-smartcontractkit-chainlink-common

Status: ✅ 2 compatible changes

(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17477042499/#summary-49639335355)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR augments the OutboundHTTPResponse struct with additional fields to support better metrics collection and adds cache age limit configuration to HTTP action settings.

  • Added error classification and latency tracking fields to OutboundHTTPResponse
  • Introduced CacheAgeLimit configuration setting for HTTP actions
  • Updated default configuration files to include the new cache age limit setting

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
pkg/types/gateway/action.go Added IsExternalEndpointError flag and ExternalEndpointLatency field to OutboundHTTPResponse struct
pkg/settings/cresettings/settings.go Added CacheAgeLimit setting to httpAction struct and default configuration
pkg/settings/cresettings/defaults.toml Added CacheAgeLimit default value in TOML format
pkg/settings/cresettings/defaults.json Added CacheAgeLimit default value in JSON format

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jinhoonbang jinhoonbang enabled auto-merge (squash) September 4, 2025 21:21
@jinhoonbang jinhoonbang merged commit 8fa1bdd into main Sep 4, 2025
19 of 20 checks passed
@jinhoonbang jinhoonbang deleted the metrics-improvements branch September 4, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants