-
Notifications
You must be signed in to change notification settings - Fork 25
augment OutboundHTTPResponse with helpful fields for metrics #1519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 jinhoonbang, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
apidiff results - no incompatible changes detected ✅Module:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR augments the OutboundHTTPResponse struct with additional fields to support better metrics collection and adds cache age limit configuration to HTTP action settings.
- Added error classification and latency tracking fields to OutboundHTTPResponse
- Introduced CacheAgeLimit configuration setting for HTTP actions
- Updated default configuration files to include the new cache age limit setting
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/types/gateway/action.go | Added IsExternalEndpointError flag and ExternalEndpointLatency field to OutboundHTTPResponse struct |
| pkg/settings/cresettings/settings.go | Added CacheAgeLimit setting to httpAction struct and default configuration |
| pkg/settings/cresettings/defaults.toml | Added CacheAgeLimit default value in TOML format |
| pkg/settings/cresettings/defaults.json | Added CacheAgeLimit default value in JSON format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
IsExternalEndpointErrorandExternalEndpointLatencycresettings