Implement encryptor in keystore library#1587
Merged
connorwstein merged 25 commits intomainfrom Oct 27, 2025
Merged
Conversation
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
✅ API Diff Results - No breaking changes |
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
reviewed
Oct 6, 2025
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
* Wip * Basic signer test * Errors new * Fix merge * Remove unnecessary lock
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
| const ( | ||
| // Maximum payload size for encrypt/decrypt operations (100kb) | ||
| // Note just an initial limit, we may want to increase this in the future. | ||
| MaxEncryptionPayloadSize = 100 * 1024 |
Contributor
There was a problem hiding this comment.
Do we allow users to pass in a limit when creating the keystore? Agree this is fine for now, but since we're going to be trusting clients to use this correctly, it would make sense for them to be able to provide the limit. (Maybe we can follow the OCR model of having a MaxMax limit)
Contributor
Author
There was a problem hiding this comment.
We don't yet but yep we can add a user facing limit with an underlying MaxMax
| k.mu.RLock() | ||
| defer k.mu.RUnlock() | ||
|
|
||
| if len(req.EncryptedData) == 0 || len(req.EncryptedData) > MaxEncryptionPayloadSize*2 { |
Contributor
There was a problem hiding this comment.
Is this potentially brittle? Can we document how we got to this number and under what circumstances it would change
Contributor
Author
There was a problem hiding this comment.
yeah I think it'd be possible in principle that we introduce some new scheme which has enormous overhead/envelope size (more than 2x), but exceedingly unlikely. Perhaps better to have explicit envelope sizes per type (at least the existing ones so far are fixed so we can start with that). Can do in a follow up
cedric-cordenier
previously approved these changes
Oct 10, 2025
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
approved these changes
Oct 27, 2025
jmank88
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note signer impl already reviewed.