Fix shutdown flush context handling in chip ingress batch client#1832
Merged
hendoxc merged 1 commit intoINFOPLAT-3099-chip-ingress-batchingfrom Feb 11, 2026
Conversation
✅ API Diff Results - No breaking changes |
hendoxc
merged commit 53d52a8
into
INFOPLAT-3099-chip-ingress-batching
23 of 24 checks passed
hendoxc
deleted the
INFOPLAT-3099-chip-ingress-batching-fix-shutdown-flush-context-timeout
branch
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
* Adds chipingress batching client * Adds unit-tests FIxes test * Removes copying of slice * Adds zap logger * Fixes mod file * FIxes linting * Rename timeout vars * Adds callback mechanism * fixes linting * Move callback execution into separate goroutine stops semaphore blocking on callback execution to complete * check for shutdown * Ensures all callbacks complete after .Stop - ensures no panic if .Stop is called multiple times * Removes compression type * Adjust configuration * Return errors from queue message * Adds buffer * Correct shutdown protocol * Fix linting errors * Fixes linting * Addresses comments * Uses `services.StopChan` derives contexts * linter fixes * Removes `services.StopChan` usage circular dependency on `common` * Make buffer generic * simplify * Removes unused functions adds comment * fix batch flush publish context on shutdown (#1832) * Removes unused code --------- Co-authored-by: Pavel <177363085+pkcll@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxPublishTimeoutinsendBatchTest plan
go test ./batch