pkg/logger: add SugaredLogger.WithCtx & CtxKeyVals#1942
Merged
Conversation
jmank88
requested review from
cedric-cordenier,
patrickhuie19,
pavel-raykov and
pkcll
jmank88
commented
Mar 30, 2026
Comment on lines
+320
to
+324
| kvs = append(kvs, "trace_id", spanCtx.TraceID().String()) | ||
| kvs = append(kvs, "trace_flags", spanCtx.TraceFlags().String()) | ||
| } | ||
| if spanCtx.HasSpanID() { | ||
| kvs = append(kvs, "span_id", spanCtx.SpanID().String()) |
Contributor
Author
There was a problem hiding this comment.
This logic is already present in our otel zap adapter. If we put slog in front of everything (and use the context variants), then we could unify the duplicate logic there instead. In the mean time, any redundancy shouldn't hurt.
|
cedric-cordenier
approved these changes
Mar 30, 2026
jmank88
commented
Mar 30, 2026
| // Example: l.With(CtxKeyVals(ctx, "keyFoo", ctxKeyFoo, "keyBar", ctxKeyBar)...) | ||
| // See: [SugaredLogger.WithCtx] | ||
| func CtxKeyVals(ctx context.Context, keyvals ...any) []any { | ||
| var kvs []any |
Contributor
Author
There was a problem hiding this comment.
Future expansion:
Suggested change
| var kvs []any | |
| var kvs []any | |
| v := ctx.Value(loggerKVKey) | |
| if v != nil { | |
| kvs = slices.Clone(v.([]any)) | |
| } |
func ContextWith(context.Context, kvs ...any) context.Context {
var kvs []any
v := ctx.Value(loggerKVKey)
if v != nil {
//TODO technically just need the order right, but should de-dupe the keys
kvs = append(kvs, v.([]any)...)
}
return context.With(loggerKVKey, kvs)
}
pavel-raykov
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
SuagaredLogger.WithCtx(and the supporting funcCtxKeyVals) for extracting otel and custom values from a context for logging.