Skip to content

Create dynamic settings for BaseTrigger#1946

Merged
DylanTinianov merged 7 commits intomainfrom
basetrigger-dynamic-config
Mar 31, 2026
Merged

Create dynamic settings for BaseTrigger#1946
DylanTinianov merged 7 commits intomainfrom
basetrigger-dynamic-config

Conversation

@DylanTinianov
Copy link
Copy Markdown
Contributor

@DylanTinianov DylanTinianov commented Mar 30, 2026

Enable / Disable trigger event retransmitting dynamically (so we don't need to restart nodes if settings are updated).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 30, 2026

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (2)

pkg/capabilities (2)
  • NewBaseTriggerCapability — Type changed:
func(
  EventStore, 
  func() T, 
  github.com/smartcontractkit/chainlink-common/pkg/logger.Logger, 
  string, 
  time.Duration, 
  time.Duration, 
  time.Duration, 
  + github.com/smartcontractkit/chainlink-common/pkg/settings.Getter
)
*BaseTriggerCapability[T]
  • ResolveBaseTriggerRetryInterval — 🗑️ Removed

✅ Compatible Changes (1)

pkg/capabilities (1)
  • ValidateBaseTriggerRetryInterval — ➕ Added

📄 View full apidiff report

Comment thread pkg/capabilities/base_trigger_test.go Outdated
Comment thread pkg/capabilities/base_trigger_test.go Outdated
@DylanTinianov DylanTinianov self-assigned this Mar 30, 2026
@DylanTinianov DylanTinianov requested a review from jmank88 March 30, 2026 22:34
jmank88
jmank88 previously approved these changes Mar 31, 2026
Comment thread pkg/capabilities/base_trigger.go Outdated
Comment thread pkg/capabilities/base_trigger.go
@DylanTinianov DylanTinianov added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit 95a68e8 Mar 31, 2026
30 of 33 checks passed
@DylanTinianov DylanTinianov deleted the basetrigger-dynamic-config branch March 31, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants