Skip to content

fix linter issues#1949

Merged
jmank88 merged 1 commit intomainfrom
lint-fix
Apr 2, 2026
Merged

fix linter issues#1949
jmank88 merged 1 commit intomainfrom
lint-fix

Conversation

@jmank88
Copy link
Copy Markdown
Contributor

@jmank88 jmank88 commented Mar 31, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2026 •
edited
Loading

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-common/observability-lib

View full report

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2026 •
edited
Loading

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (4)

pkg/capabilities (2)
  • NewBaseTriggerCapability — Type changed:
func(
  EventStore, 
  func() T, 
  github.com/smartcontractkit/chainlink-common/pkg/logger.Logger, 
  string, 
  time.Duration, 
  time.Duration, 
  - time.Duration, 
  - github.com/smartcontractkit/chainlink-common/pkg/settings.Getter
  + time.Duration
)
*BaseTriggerCapability[T]
  • ValidateBaseTriggerRetryInterval — 🗑️ Removed
pkg/settings/cresettings.Orgs (1)
  • WorkflowExecutionConcurrencyLimit — 🗑️ Removed
pkg/settings/cresettings.Owners (1)
  • WorkflowLimit — 🗑️ Removed

✅ Compatible Changes (1)

pkg/capabilities (1)
  • ResolveBaseTriggerRetryInterval — ➕ Added

📄 View full apidiff report

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2026 •
edited
Loading

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-common/pkg/monitoring

View full report

@jmank88 jmank88 marked this pull request as ready for review March 31, 2026 18:34
@jmank88 jmank88 requested review from a team as code owners March 31, 2026 18:34
@product-security-plaid-production product-security-plaid-production Bot requested review from chainchad and tarcisiozf and removed request for tarcisiozf March 31, 2026 18:34
jmank88
jmank88 commented Mar 31, 2026
View reviewed changes
Comment thread pkg/workflows/dontime/plugin.go
)

type Plugin struct {
mu sync.RWMutex
Copy link
Copy Markdown
Contributor Author

@jmank88 jmank88 Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DylanTinianov can you confirm that these unused things are OK to just remove? Or were they meant to be used?

@jmank88 jmank88 added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit a1e262d Apr 2, 2026
35 of 38 checks passed
@jmank88 jmank88 deleted the lint-fix branch April 2, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@makramkd makramkd makramkd approved these changes

@kalverra kalverra kalverra approved these changes

@anirudhwarrier anirudhwarrier anirudhwarrier approved these changes

@DylanTinianov DylanTinianov DylanTinianov approved these changes

@chainchad chainchad chainchad approved these changes

@pavel-raykov pavel-raykov pavel-raykov approved these changes

@pkcll pkcll pkcll approved these changes

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@matYang matYang Awaiting requested review from matYang matYang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@KodeyThomas KodeyThomas Awaiting requested review from KodeyThomas KodeyThomas is a code owner automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@bolekk bolekk Awaiting requested review from bolekk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jmank88 @makramkd @kalverra @anirudhwarrier @DylanTinianov @chainchad @pavel-raykov @pkcll