pkg/contexts: remove org ID normalization#1995
Merged
Conversation
jmank88
requested review from
DylanTinianov,
cedric-cordenier and
patrickhuie19
📊 API Diff Results
|
jmank88
commented
Apr 22, 2026
Comment on lines
43
to
47
| c.Owner = strings.TrimPrefix(c.Owner, "0x") | ||
| c.Owner = strings.ToLower(c.Owner) | ||
|
|
||
| c.Workflow = strings.TrimPrefix(c.Workflow, "0x") | ||
| c.Workflow = strings.ToLower(c.Workflow) |
Contributor
Author
There was a problem hiding this comment.
Are these problematic too? Or OK since they are a stricter hex format?
Contributor
There was a problem hiding this comment.
I think those are OK 👍 We already do some normalization in various places so they're less problematic
patrickhuie19
approved these changes
Apr 22, 2026
pavel-raykov
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/CRE-3673
This PR updates
CRE.Normalized()to leave the org id unmodified.