Skip to content

pkg/loop/internal/net: classify Canceled as non terminal#2009

Merged
jmank88 merged 1 commit intomainfrom
loop-terminal-errs
Apr 28, 2026
Merged

pkg/loop/internal/net: classify Canceled as non terminal#2009
jmank88 merged 1 commit intomainfrom
loop-terminal-errs

Conversation

@jmank88
Copy link
Copy Markdown
Contributor

@jmank88 jmank88 commented Apr 28, 2026

GRPC Canceled errors were being classified as terminal, causing unnecessary connection refreshes, which can compound and cascade when under high load.

Originally introduced in #108

@jmank88 jmank88 requested a review from krebernisak April 28, 2026 18:02
@github-actions
Copy link
Copy Markdown

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-common

View full report

@jmank88 jmank88 marked this pull request as ready for review April 28, 2026 18:27
@jmank88 jmank88 requested a review from a team as a code owner April 28, 2026 18:27
@jmank88 jmank88 enabled auto-merge April 28, 2026 18:59
@jmank88 jmank88 requested review from bolekk, ilija42 and nolag April 28, 2026 19:16
@jmank88 jmank88 added this pull request to the merge queue Apr 28, 2026
Merged via the queue into main with commit b1f4aeb Apr 28, 2026
35 of 36 checks passed
@jmank88 jmank88 deleted the loop-terminal-errs branch April 28, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants