(feat): Enable per-owner overrides for the max ciphertext size#2121
Merged
Conversation
|
👋 justinkaseman, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results -
|
Contributor
There was a problem hiding this comment.
Pull request overview
Enables configuring VaultCiphertextSizeLimit as an owner-scoped setting (with global.PerOwner.* acting as a global override for all owners), by moving the setting definition and its defaults from the global schema into the PerOwner scope.
Changes:
- Move
VaultCiphertextSizeLimitfrom global schema settings into thePerOwnersettings group. - Update generated defaults (
defaults.json,defaults.toml) to reflect the new key path. - Update the CRE settings flowchart in
README.mdto reflect the new location of the setting.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/settings/cresettings/settings.go | Moves VaultCiphertextSizeLimit into PerOwner scope and updates the default schema accordingly. |
| pkg/settings/cresettings/README.md | Updates the mermaid flowchart to reference PerOwner.VaultCiphertextSizeLimit instead of the global key. |
| pkg/settings/cresettings/defaults.toml | Removes the global VaultCiphertextSizeLimit entry and adds it under [PerOwner]. |
| pkg/settings/cresettings/defaults.json | Removes the global VaultCiphertextSizeLimit entry and adds it under PerOwner. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // DANGER(cedric): Be extremely careful changing this vault limit as it acts as a default value | ||
| // used by the Vault OCR plugin -- changing this value could cause issues with the plugin during an image | ||
| // DANGER(cedric): Be extremely careful changing these vault limits as they act as a default value |
cedric-cordenier
previously approved these changes
Jun 4, 2026
Comment on lines
+81
to
84
|
|
||
| // Deprecated: Use global.PerOwner.VaultCiphertextSizeLimit (global) or owner.<addr>.PerOwner.VaultCiphertextSizeLimit (per owner) instead. | ||
| VaultCiphertextSizeLimit: Size(2 * config.KByte), | ||
| VaultIdentifierKeySizeLimit: Size(64 * config.Byte), |
Comment on lines
+281
to
283
| // Deprecated: Use global.PerOwner.VaultCiphertextSizeLimit (global) or owner.<addr>.PerOwner.VaultCiphertextSizeLimit (per owner) instead. | ||
| VaultCiphertextSizeLimit Setting[config.Size] | ||
| VaultShareSizeLimit Setting[config.Size] |
cedric-cordenier
previously approved these changes
Jun 4, 2026
cedric-cordenier
approved these changes
Jun 4, 2026
russell-stern
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
global.VaultCiphertextSizeLimitAfter:
owner.<addr>.PerOwner.VaultCiphertextSizeLimit= per-owner overrideglobal.PerOwner.VaultCiphertextSizeLimit= global override (applies to all owners)Backwards compatibility:
CL_CRE_SETTINGS, it stops being found so falls back to 2KB defaultFor OCR safety: only CL_CRE_SETTINGS needs to be checked for the old key, and configuring the new override should only be done after all nodes of the DON have upgraded.