Skip to content

Add stellar key support#2125

Merged
ilija42 merged 1 commit into
mainfrom
add-stellar-keystore
Jun 5, 2026
Merged

Add stellar key support#2125
ilija42 merged 1 commit into
mainfrom
add-stellar-keystore

Conversation

@ilija42
Copy link
Copy Markdown
Contributor

@ilija42 ilija42 commented Jun 4, 2026

Copilot AI review requested due to automatic review settings June 4, 2026 12:33
@ilija42 ilija42 requested review from a team as code owners June 4, 2026 12:33
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

👋 ilija42, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

✅ API Diff Results - github.com/smartcontractkit/chainlink-common/keystore

✅ Compatible Changes (3)

corekeys (1)
  • Stellar — ➕ Added
corekeys/models.KeyRing (1)
  • Stellar — ➕ Added
package github (1)
  • com/smartcontractkit/chainlink-common/keystore/corekeys/stellarkey — ➕ Added

📄 View full apidiff report

@ilija42 ilija42 force-pushed the add-stellar-keystore branch from 7e9a5c0 to 0ca640c Compare June 4, 2026 12:34
@ilija42 ilija42 requested a review from pavel-raykov June 4, 2026 12:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Stellar (Soroban) key support to the keystore module, integrating a new stellarkey implementation and wiring it into existing keyring serialization and OCR2 key bundle chain-type handling.

Changes:

  • Added a new stellarkey core key type (ed25519 seed-backed) with StrKey (“G…”) account address derivation, signing, and encrypted JSON import/export.
  • Extended core keyring models/serialization to persist and restore Stellar keys.
  • Added corekeys.Stellar chain type and enabled Stellar in OCR2 key bundle creation/import; updated module dependencies to include Stellar SDK + transitive updates.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
keystore/go.mod Adds Stellar SDK dependency and updates several direct/indirect module versions.
keystore/go.sum Records checksums for new/updated dependencies (including Stellar SDK and transitive upgrades).
keystore/corekeys/stellarkey/key.go Implements Stellar key (ed25519) with StrKey “G…” account address ID and signing.
keystore/corekeys/stellarkey/key_test.go Adds test vectors for StrKey address derivation and ed25519 signature verification.
keystore/corekeys/stellarkey/export.go Adds encrypted JSON export/import for Stellar keys following existing key patterns.
keystore/corekeys/stellarkey/export_test.go Adds export/import roundtrip test using shared core key test utility.
keystore/corekeys/ocr2key/key_bundle.go Enables corekeys.Stellar to create/load OCR2 ed25519 key bundles.
keystore/corekeys/ocr2key/export.go Adds Stellar handling when importing OCR2 key bundles from encrypted JSON.
keystore/corekeys/models/models.go Adds Stellar to KeyRing and to encrypted keyring (raw) serialization/deserialization.
keystore/corekeys/chaintype.go Introduces Stellar chain type, numeric mapping, and supported chain list update.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ilija42 ilija42 enabled auto-merge June 4, 2026 12:56
@ilija42 ilija42 requested review from jmank88 and yashnevatia June 4, 2026 14:34
@ilija42 ilija42 added this pull request to the merge queue Jun 5, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 5, 2026
@ilija42 ilija42 added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit 0a11f78 Jun 5, 2026
32 of 33 checks passed
@ilija42 ilija42 deleted the add-stellar-keystore branch June 5, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants