Add stellar key support#2125
Merged
Merged
Conversation
|
👋 ilija42, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results -
|
7e9a5c0 to
0ca640c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Stellar (Soroban) key support to the keystore module, integrating a new stellarkey implementation and wiring it into existing keyring serialization and OCR2 key bundle chain-type handling.
Changes:
- Added a new
stellarkeycore key type (ed25519 seed-backed) with StrKey (“G…”) account address derivation, signing, and encrypted JSON import/export. - Extended core keyring models/serialization to persist and restore Stellar keys.
- Added
corekeys.Stellarchain type and enabled Stellar in OCR2 key bundle creation/import; updated module dependencies to include Stellar SDK + transitive updates.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
keystore/go.mod |
Adds Stellar SDK dependency and updates several direct/indirect module versions. |
keystore/go.sum |
Records checksums for new/updated dependencies (including Stellar SDK and transitive upgrades). |
keystore/corekeys/stellarkey/key.go |
Implements Stellar key (ed25519) with StrKey “G…” account address ID and signing. |
keystore/corekeys/stellarkey/key_test.go |
Adds test vectors for StrKey address derivation and ed25519 signature verification. |
keystore/corekeys/stellarkey/export.go |
Adds encrypted JSON export/import for Stellar keys following existing key patterns. |
keystore/corekeys/stellarkey/export_test.go |
Adds export/import roundtrip test using shared core key test utility. |
keystore/corekeys/ocr2key/key_bundle.go |
Enables corekeys.Stellar to create/load OCR2 ed25519 key bundles. |
keystore/corekeys/ocr2key/export.go |
Adds Stellar handling when importing OCR2 key bundles from encrypted JSON. |
keystore/corekeys/models/models.go |
Adds Stellar to KeyRing and to encrypted keyring (raw) serialization/deserialization. |
keystore/corekeys/chaintype.go |
Introduces Stellar chain type, numeric mapping, and supported chain list update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pavel-raykov
approved these changes
Jun 4, 2026
yashnevatia
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core followup