feat: load network_types from domain config
#338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5680f34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
giogam
changed the title
|
giogam
commented
Aug 28, 2025
| } | ||
|
|
||
| // getLegacyNetworkTypes returns network types based on legacy switch logic. | ||
| func getLegacyNetworkTypes(env string, domain cldf_domain.Domain, lggr logger.Logger) ([]cldf_config_network.NetworkType, error) { |
Contributor
Author
There was a problem hiding this comment.
The current logic has been moved into its own method.
giogam
changed the title
giogam
changed the title
network_types from domain config
graham-chainlink
approved these changes
Aug 28, 2025
giogam
deleted the
CLD-505/update-chainlink-deployments-to-load-network-access-config
branch
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 29, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.37.1 ### Patch Changes - [#338](#338) [`d207c3b`](d207c3b) Thanks [@giogam](https://github.com/giogam)! - feat: load network types from domain config - [#344](#344) [`cf1cc45`](cf1cc45) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - fix(operations): handle missing case causing Operations APi unable to serialize certain Marshalable struct - [#345](#345) [`ba11ea0`](ba11ea0) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - Migrated Dry Run JD Client from CLD --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
LoadNetworksto support the newly introduced domain config at/domains/.config/domain.yaml.Behavior:
The legacy logic based on predefined environment names will remain for backward compatibility until the migration to the new configuration is complete, after which it will be deprecated.