fix flake #355
Merged
fix flake #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f16d7e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 bytesizedroll, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
…m/smartcontractkit/chainlink-deployments-framework into CLD-583/flakey-test-register-node
|
graham-chainlink
approved these changes
Sep 2, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.39.0 ### Minor Changes - [#357](#357) [`8289afa`](8289afa) Thanks [@jkongie](https://github.com/jkongie)! - Moves `environment.Config` to `config.Config` - [#352](#352) [`5088d9c`](5088d9c) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - fix: migrate Update Node from CLD ### Patch Changes - [#355](#355) [`63d8f65`](63d8f65) Thanks [@bytesizedroll](https://github.com/bytesizedroll)! - Fix flaky test in TestRegisterNode_Success_Plugin - [#358](#358) [`6ef6875`](6ef6875) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - Migrate LoadCatalogStore and LoadJDClient to engine - [#356](#356) [`fd159c8`](fd159c8) Thanks [@giogam](https://github.com/giogam)! - feat(environment): removes getLegacyNetworkTypes --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky test in TestRegisterNode_Success_Plugin
Problem
The
TestRegisterNode_Success_Plugintest was flaky due to non-deterministic map iteration order in Go. The test expected labels in a specific order, but Go's map iteration order is not guaranteed, causing intermittent failures in CI.Solution
extraLabelsmap keys alphabetically before iterating to ensure deterministic label orderingsortimport toregister_node.go