fix(mcms): check PostOpCountReached errors in Solana#475
Merged
gustavogama-cll merged 1 commit intomainfrom Oct 2, 2025
Merged
fix(mcms): check PostOpCountReached errors in Solana#475gustavogama-cll merged 1 commit intomainfrom
gustavogama-cll merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 6e7e69d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gustavogama-cll
force-pushed
the
ggama/fix-solana-check-postopcountreached-error
branch
from
d4c39cb to
810822b
Compare
gustavogama-cll
force-pushed
the
ggama/fix-solana-check-postopcountreached-error
branch
from
810822b to
6e7e69d
Compare
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes error handling in the MCMS (Multi-Chain Management System) for Solana by adding detection of "PostOpCountReached" errors alongside existing "WrongNonce" error handling.
- Extended Solana error checking to handle PostOpCountReached errors as nonce-related errors
- Added changeset documenting the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| engine/cld/legacy/cli/mcmsv2/mcms_v2.go | Extended isNonceError function to check for PostOpCountReached errors in Solana |
| .changeset/olive-buttons-visit.md | Added changeset entry documenting the bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
graham-chainlink
approved these changes
Oct 2, 2025
gustavogama-cll
deleted the
ggama/fix-solana-check-postopcountreached-error
branch
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.54.0 ### Minor Changes - [#481](#481) [`1f7f6bc`](1f7f6bc) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - feat(operations): introduce AsUntypedRelaxed ### Patch Changes - [#484](#484) [`fb9d9bf`](fb9d9bf) Thanks [@jkongie](https://github.com/jkongie)! - Fixes test engine MCMS execution when multiple proposals have the same `validUntil` timestamp. A salt override is added to each timelock proposal persisted to the state to ensure unique operation IDs in test environments where multiple proposals may have identical timestamps. This salt is used in the hashing algorithm to determine the root of the merkle tree. - [#479](#479) [`930e469`](930e469) Thanks [@jkongie](https://github.com/jkongie)! - Fixes MCMS Execution failing to Set Root in the test engine - [#475](#475) [`8d9ded3`](8d9ded3) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - fix(mcms): check for PostOpCountReached errors in Solana as well --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.