Conversation
Contributor
Static analysis results are availableHey @DeividasK, you can view Slither reports in the job summary here or download them as artifact here. |
justinkaseman
force-pushed
the
CRE-774-2
branch
from
564b0b7 to
7f46cf5
Compare
justinkaseman
force-pushed
the
CRE-774-3
branch
from
e667c38 to
fbfd5b6
Compare
mchain0
previously approved these changes
Sep 8, 2025
# Conflicts: # contracts/gas-snapshots/workflow.gas-snapshot # gethwrappers/workflow/generated/capabilities_registry_wrapper_v2_dev/capabilities_registry_wrapper_v2_dev.go # gethwrappers/workflow/generation/generated-wrapper-dependency-versions-do-not-edit.txt
ibrajer
reviewed
Sep 9, 2025
| ) external onlyOwner { | ||
| for (uint32 i; i < nodeOperatorIds.length; ++i) { | ||
| uint32 nodeOperatorId = nodeOperatorIds[i]; | ||
| NodeOperator memory nodeOperator = s_nodeOperators[nodeOperatorId]; |
Contributor
There was a problem hiding this comment.
What if someone sends a node operation ID outside of the current range? For example, s_nodeOperators contains 10 nodes, but someone sent a list of node operator IDs: 20, 21, 22. Do we want to proceed with deletion if nodeOperator comes out empty?
Contributor
There was a problem hiding this comment.
Do we want to proceed with deletion if
nodeOperatorcomes out empty?
Yes, as this would be a no-op. Reverting wouldn't serve much of a purpose here.
ibrajer
approved these changes
Sep 9, 2025
DeividasK
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are no checks to prevent duplicate Node Operators from being added to the Capabilities Registry.
This PR ensures that Node Operators are unique by
hash(admin, name)by adding a lookup mapping for if the data has been set.