Conversation
product-security-plaid-test
Bot
requested review from
leeyikjiun and
michael-cll
Contributor
Static analysis results are availableHey @DeividasK, you can view Slither reports in the job summary here or download them as artifact here. |
justinkaseman
force-pushed
the
CRE-774-4
branch
from
972287b to
39c084a
Compare
justinkaseman
requested review from
bolekk and
eutopian
and removed request for
leeyikjiun and
michael-cll
justinkaseman
force-pushed
the
CRE-774-4
branch
from
39c084a to
7be5a53
Compare
justinkaseman
force-pushed
the
CRE-774-3
branch
from
e667c38 to
fbfd5b6
Compare
…ttached to a node
justinkaseman
force-pushed
the
CRE-774-4
branch
from
7be5a53 to
f091b12
Compare
mchain0
previously approved these changes
Sep 8, 2025
# Conflicts: # contracts/gas-snapshots/workflow.gas-snapshot # contracts/src/v0.8/workflow/dev/v2/CapabilitiesRegistry.sol # contracts/src/v0.8/workflow/dev/v2/test/CapabilitiesRegistry/CapabilitiesRegistry_AddNodeOperatorsTest.t.sol # contracts/src/v0.8/workflow/dev/v2/test/CapabilitiesRegistry/CapabilitiesRegistry_UpdateNodeOperatorsTest.t.sol # gethwrappers/workflow/generated/capabilities_registry_wrapper_v2_dev/capabilities_registry_wrapper_v2_dev.go # gethwrappers/workflow/generation/generated-wrapper-dependency-versions-do-not-edit.txt
DeividasK
approved these changes
Sep 10, 2025
ibrajer
reviewed
Sep 10, 2025
| /// a trusted admin will supply these names. We reduce gas costs by omitting these checks on-chain. | ||
| string name; | ||
| /// @notice The P2P IDs of the nodes that this Node Operator owns | ||
| bytes32[] nodeP2PIDs; |
Contributor
There was a problem hiding this comment.
In case we do something like this:
struct NodeOperatorInfo {
NodeOperatorParams params;
bytes32[] nodeP2PIDs;
}
Would it result in the same storage and memory layout?
Contributor
There was a problem hiding this comment.
It would be a nested structure and, I think, it would have the same storage and memory layout, yes. Generally, it seems that the practice is to flatten the structs, but I don't have a strong pref 🤷♂️
ibrajer
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To prevent NOPs from being deleted if still in use, adds an EnumerableSet of bytes32 P2PIDs to the Node Operator struct.
A new struct
NodeOperatorParamsacts as the Node Operator structure for parameters and query info.