[CRE-494] Start LogPoller with other services.#219
Merged
Conversation
pavel-raykov
force-pushed
the
start-logpoller2
branch
from
e4ddb48 to
8d5a08d
Compare
jmank88
approved these changes
Sep 5, 2025
pavel-raykov
force-pushed
the
start-logpoller2
branch
from
8d5a08d to
b4396bd
Compare
product-security-plaid-test
Bot
requested review from
fernandezlautaro,
george-dorin and
matYang
ChrisAmora
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR we would only start logPoller externally. After this PR we start it explicitly with other services. The removed comment "it gets started after the jobs, so they have a chance to apply their filters" suggests that the logPoller should be started after other services, however, this does not seem to hold anymore. We checked the logs and it seems all the filters are loaded by the logPoller from the underlying db, meaning that the filter registration by the other jobs is a no-op.
Supports smartcontractkit/chainlink#19264