Set default FinalityTagEnabled on polygon and amoy to be false#237
Merged
Conversation
product-security-plaid-test
Bot
requested review from
Atrax1,
RensR and
ilija42
Contributor
|
👋 infiloop2, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
pavel-raykov
changed the title
pavel-raykov
previously approved these changes
Sep 16, 2025
Collaborator
|
Can you please fix the codeowners for this folder? It should not be the catch-all |
ilija42
approved these changes
Sep 16, 2025
Contributor
Author
|
@RensR addressed comment if you can help review |
RensR
approved these changes
Sep 17, 2025
Contributor
Author
|
per conversation on slack https://chainlink-core.slack.com/archives/C01616631EU/p1757413408051909 , aligned that this is good to set as default for products. Merging PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple products have faced issue with this config as polygon has sent reorgs on blocks previously sent with finality tags.
Most products override this manually, changing the default for safety in future