Reverse search allowlisted requests with tight packing and stop criteria#245
Merged
Conversation
ibrajer
force-pushed
the
update-request-allowlist-search
branch
from
8a15505 to
938b8df
Compare
Contributor
infiloop2
reviewed
Sep 29, 2025
infiloop2
reviewed
Sep 29, 2025
infiloop2
reviewed
Sep 29, 2025
infiloop2
previously approved these changes
Sep 29, 2025
* --wip-- [skip CI] * Logic and test fixes * --wip-- [skip CI] * Fixes failing tests and updated snapshot --------- Co-authored-by: Iva Brajer <iva.brajer@smartcontract.com>
infiloop2
previously approved these changes
Sep 30, 2025
infiloop2
previously approved these changes
Sep 30, 2025
DeividasK
reviewed
Sep 30, 2025
DeividasK
reviewed
Sep 30, 2025
DeividasK
reviewed
Sep 30, 2025
DeividasK
previously approved these changes
Sep 30, 2025
DeividasK
previously approved these changes
Sep 30, 2025
DeividasK
approved these changes
Sep 30, 2025
infiloop2
approved these changes
Sep 30, 2025
shileiwill
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new function that supports reverse search of allowlisted requests, tight packing per page returned, and disclosing stop flag that will indicate to the caller when it's safe to abort the search.