Avoid stale entries in Workflow Registry#273
Merged
Merged
Conversation
Contributor
ibrajer
force-pushed
the
workflow-registry-stale-entries
branch
from
89e80bf to
f87103d
Compare
DeividasK
reviewed
Oct 14, 2025
| vm.stopPrank(); | ||
| } | ||
|
|
||
| function test_upsertWorkflow_WhenDonFamilyIsChangedOnUpdateWorkflow() |
Contributor
There was a problem hiding this comment.
Suggested change
| function test_upsertWorkflow_WhenDonFamilyIsChangedOnUpdateWorkflow() | |
| function test_RevertWhen_upsertWorkflow_WhenDonFamilyIsChangedOnUpdateWorkflow() |
Tests that are expected to revert must have a _RevertWhen_ affix as per the Solidity style guide.
DeividasK
previously approved these changes
Oct 14, 2025
Atrax1
previously approved these changes
Oct 14, 2025
ibrajer
force-pushed
the
workflow-registry-stale-entries
branch
from
22157a7 to
b911076
Compare
infiloop2
approved these changes
Oct 14, 2025
DeividasK
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.