Various onchain fixes#291
Merged
Merged
Conversation
Collaborator
RensR
commented
Oct 31, 2025
RensR
commented
- NPM dependency bumps
- CI fix for releasing NPM packages
- Various warnings in contracts
- Foundry bump
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| - name: Publish to NPM (beta) | ||
| uses: smartcontractkit/.github/actions/ci-publish-npm@4b0ab756abcb1760cb82e1e87b94ff431905bffc # ci-publish-npm@0.4.0 | ||
| uses: smartcontractkit/.github/actions/ci-publish-npm@ci-publish-npm/v1 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
|
|
||
| - name: Publish to NPM (latest) | ||
| uses: smartcontractkit/.github/actions/ci-publish-npm@4b0ab756abcb1760cb82e1e87b94ff431905bffc # ci-publish-npm@0.4.0 | ||
| uses: smartcontractkit/.github/actions/ci-publish-npm@ci-publish-npm/v1 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Contributor
product-security-plaid-production
Bot
requested review from
RayXpub,
archseer,
chainchad,
george-dorin,
j-nowak and
skudasov
RensR
commented
Nov 3, 2025
| p2pIds[0] = keccak256(abi.encodePacked("invalid")); | ||
|
|
||
| vm.expectRevert(abi.encodeWithSelector(INodeInfoProvider.NodeDoesNotExist.selector, p2pIds[0])); | ||
| CapabilitiesRegistry.NodeInfo[] memory nodes = s_CapabilitiesRegistry.getNodesByP2PIds(p2pIds); |
Collaborator
Author
There was a problem hiding this comment.
linting fixes in tests
RensR
commented
Nov 3, 2025
| libs = ['node_modules'] | ||
| bytecode_hash = "none" | ||
| ffi = false | ||
| deny_warnings = true |
Collaborator
Author
There was a problem hiding this comment.
This makes warnings stop compilation by default. Below are a few projects that turn this off due to the existing warnings.
RensR
commented
Nov 3, 2025
| test = 'src/v0.8/shared/test' | ||
| solc_version = '0.8.26' | ||
| evm_version = 'paris' | ||
| ignored_error_codes = [8417] |
Collaborator
Author
There was a problem hiding this comment.
Can't fix this warning right now so ignoring it to allow enabling deny_warnings
RensR
commented
Nov 3, 2025
| # See more config options https://github.com/foundry-rs/foundry/tree/master/config | ||
|
|
||
| [lint] | ||
| lint_on_build = false No newline at end of file |
Collaborator
Author
There was a problem hiding this comment.
Needed for the forge bump
RayXpub
approved these changes
Nov 3, 2025
j-nowak
approved these changes
Nov 3, 2025
mohamed-mehany
approved these changes
Nov 3, 2025
Contributor
mohamed-mehany
left a comment
mohamed-mehany
left a comment
There was a problem hiding this comment.
L2EP changes look good!
jmank88
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.