Bump NPM deps#305
Merged
Merged
Conversation
RensR
commented
Dec 2, 2025
|
|
||
| # Root | ||
| * @smartcontractkit/foundations @smartcontractkit/core @smartcontractkit/bix-framework @smartcontractkit/core-solidity | ||
| * @smartcontractkit/foundations @smartcontractkit/core @smartcontractkit/bix-framework |
Collaborator
Author
There was a problem hiding this comment.
Removed as core-solidity only owns Solidity related folder, not the top level which is largely Go based files.
RensR
commented
Dec 2, 2025
| @@ -1,4 +1,4 @@ | |||
| # Test files run with a different solhint ruleset, ignore them here. | |||
| ./**/*.t.sol | |||
| **/*.t.sol | |||
Collaborator
Author
There was a problem hiding this comment.
Syntax to define these has changed, ./ prefixed no longer works
Contributor
RensR
commented
Dec 2, 2025
| "gas-increment-by-one": "off", | ||
| "gas-small-strings": "off", | ||
| "gas-strict-inequalities": "off", | ||
| "gas-indexed-events": "off", |
Collaborator
Author
There was a problem hiding this comment.
Turn off most new rules to not break CI
RensR
force-pushed
the
bump-npm-depss
branch
from
36f9a08 to
367c4e9
Compare
product-security-plaid-production
Bot
requested review from
MStreet3,
Unheilbar,
chray-zhang,
elatoskinas and
timothyF95
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates NPM dependencies across the project, most notably upgrading solhint from v5.2.0 to v6.0.1, which enabled new linting rules by default. The PR addresses this by removing unused imports and disabling most new gas optimization rules in solhint configuration files. Additionally, it includes miscellaneous cleanup: updating CODEOWNERS to add core-solidity as owner of gethwrappers while removing them as root owner, resolving a temporary comment in the CRE go.mod, and updating solhintignore patterns.
- Bumped various NPM dependencies including @changesets/cli, TypeScript tooling, and solhint
- Disabled new default solhint gas optimization rules and removed unused imports
- Updated CODEOWNERS and resolved temporary go.mod replacement
Reviewed changes
Copilot reviewed 16 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated @changesets/cli from 2.28.1 to 2.29.7 |
| contracts/package.json | Updated multiple dev dependencies and reorganized dependency lists, removing test script |
| contracts/cre/package.json | Moved dependencies between devDependencies and dependencies sections, updated versions |
| contracts/cre/gobindings/go.mod | Replaced local module replacement with actual version reference |
| contracts/src/v0.8/data-feeds/DataFeedsCache.sol | Added solhint disable comment for gas-calldata-parameters rule |
| contracts/cre/src/workflow/v2/CapabilitiesRegistry.sol | Added solhint disable comment for gas-calldata-parameters rule |
| contracts/cre/src/keystone/test/CapabilitiesRegistry_GetHashedCapabilityIdTest.t.sol | Removed unused imports |
| contracts/cre/src/keystone/test/CapabilitiesRegistry_AddCapabilitiesTest.t.sol | Removed unused import |
| contracts/cre/src/keystone/CapabilitiesRegistry.sol | Reordered imports and removed duplicate |
| contracts/cre/.solhintignore-test | Simplified ignore patterns removing ./ prefix |
| contracts/cre/.solhintignore | Simplified ignore patterns removing ./ and .**/ prefixes |
| contracts/.solhintignore-test | Simplified ignore patterns and removed keystone directory entry |
| contracts/.solhintignore | Simplified ignore patterns removing ./ prefix |
| contracts/.solhint.json | Added multiple disabled gas optimization rules |
| contracts/.solhint-test.json | Added multiple disabled gas optimization rules |
| .github/CODEOWNERS | Removed core-solidity from root ownership, added as owner of gethwrappers |
Files not reviewed (3)
- contracts/cre/pnpm-lock.yaml: Language not supported
- contracts/pnpm-lock.yaml: Language not supported
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RayXpub
approved these changes
Dec 10, 2025
timothyF95
approved these changes
Dec 10, 2025
| /// @notice Checks to see if this data ID, msg.sender, workflow owner, and workflow name are permissioned | ||
| /// @param dataId The data ID for the feed | ||
| /// @param workflowMetadata workflow metadata | ||
| // solhint-disable-next-line gas-calldata-parameters |
augustbleeds
approved these changes
Dec 10, 2025
Contributor
augustbleeds
left a comment
augustbleeds
left a comment
There was a problem hiding this comment.
approving the solhint comment (Cache contract)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps various NPM dependencies. One of them, solhint, turned on a lot of new rules by default. Some of the issues are fixed (unused imports) but most new rules are simply turned off. Owners of Solidity code should review which rules should be enabled for them.
The PR also does some misc stuff
To be removed once the first PR with this package is mergedcomment in the CRE go.mod