Lower max attempts flag if there are no in-flight and unstarted trans…#314
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a metric update to indicate that no transactions have reached maximum retry attempts when all transactions for an address are confirmed. The change ensures the ReachedMaxAttempts metric is properly reset during the backfill process when there are no unconfirmed transactions remaining.
Key Changes
- Updates the
ReachedMaxAttemptsmetric tofalsewhen all transactions are confirmed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
👋 dimriou, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
dhaidashenko
approved these changes
Dec 19, 2025
patrickhuie19
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lowers the max attempts flag if there are no transactions left to process. This eliminates false positives.