Skip to content

[L-01] Fix LogPoller: skip backup poller ticker when disabled#427

Merged
ilija42 merged 1 commit intodevelopfrom
plex-2779-backup-log-poller
Apr 24, 2026
Merged

[L-01] Fix LogPoller: skip backup poller ticker when disabled#427
ilija42 merged 1 commit intodevelopfrom
plex-2779-backup-log-poller

Conversation

@dhaidashenko
Copy link
Copy Markdown
Contributor

No description provided.

@dhaidashenko dhaidashenko requested a review from a team as a code owner April 16, 2026 17:38
Copilot AI review requested due to automatic review settings April 16, 2026 17:38
@github-actions
Copy link
Copy Markdown
Contributor

👋 dhaidashenko, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-evm

⚠️ Breaking Changes (2)

pkg/txm.ErrorHandler (1)
  • HandleError — Type changed:
func(
  context.Context, 
  - github.com/smartcontractkit/chainlink-common/pkg/logger.Logger, 
  *github.com/smartcontractkit/chainlink-evm/pkg/txm/types.Transaction, 
  error, 
  TxStore, 
  func(github.com/ethereum/go-ethereum/common.Address, 
  uint64), 
  + bool
)
- (bool, error)
+ error
pkg/txm/clientwrappers/dualbroadcast.(*errorHandler) (1)
  • HandleError — Type changed:
func(
  context.Context, 
  - github.com/smartcontractkit/chainlink-common/pkg/logger.Logger, 
  *github.com/smartcontractkit/chainlink-evm/pkg/txm/types.Transaction, 
  error, 
  github.com/smartcontractkit/chainlink-evm/pkg/txm.TxStore, 
  func(github.com/ethereum/go-ethereum/common.Address, 
  uint64), 
  + bool
)
- (bool, error)
+ error

📄 View full apidiff report

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the LogPoller run loop to avoid creating and selecting on the backup poller ticker when the backup poller is disabled, reducing unnecessary wakeups.

Changes:

  • Create the backup poller ticker only when backupPollerBlockDelay > 0, otherwise leave the select channel nil.
  • Replace case <-backupLogPollTicker.C with case <-backupLogPollCh so the select case is effectively disabled when the backup poller is off.
  • Add an info log when the backup poller is disabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/logpoller/log_poller.go
@ilija42 ilija42 merged commit 8790b15 into develop Apr 24, 2026
39 checks passed
@ilija42 ilija42 deleted the plex-2779-backup-log-poller branch April 24, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants