Emit beholder message for Atlas userOp by dimriou · Pull Request #447 · smartcontractkit/chainlink-evm

dimriou · 2026-04-24T11:17:32Z

Depends on (need to bump dep ref after merge):

Add Fastlane Atlas userOp message chainlink-protos#344

This PR enables sending userOp data.

github-actions · 2026-04-24T11:19:38Z

⚠️ API Diff Results - `github.com/smartcontractkit/chainlink-evm`

⚠️ Breaking Changes (1)

`pkg/txm/clientwrappers/dualbroadcast.Response` (1)

Error — Type changed:

  struct{ErrorMessage string "json:\"message,
  - omitempty\""}
  + omitempty\""; Data struct{UserOpHash github.com/ethereum/go-ethereum/common.Hash "json:\"userOpHash,
  + omitempty\""}}
)

📄 View full apidiff report

cll-gg · 2026-04-27T11:35:27Z

 	req.Header.Add("Content-Type", "application/json")

 	resp, err := http.DefaultClient.Do(req)
+	responseReceivedAt := time.Now().UnixMicro()


Do we need microseconds?

It's used here, I was just being consistent.

Good point, then I guess there's a reason for it, though I can't remember why we didn't just use UnixMilli()

cll-gg · 2026-04-27T11:37:33Z

 	a.metrics.RecordBidsReceived(ctx, len(response.Result.SOS))
+	userOpHash := common.Hash{}
+	if response.Result.DO != nil {
+		userOpHash = response.Result.DO.UserOpHash //


Empty comment?

cll-gg · 2026-04-27T11:40:03Z

+		UseProtoNames:   true,
+		EmitUnpopulated: true,
+	}.Format(msg)
+	m.lggr.Infow("[Beholder.emit]", "message", mStr, "attributes", attrKVs)


Maybe this should be debug, it will pollute the logs a lot

cll-gg · 2026-04-27T11:41:54Z

 	m.lggr.Debugw("Successfully emitted Atlas error event to Beholder", "message", mStr, "attributes", attrKVs)
 }
+
+func (m *MetaMetrics) emitAtlasUserOp(ctx context.Context, userOpHash common.Hash, tx *types.Transaction, requestSentAt, responseReceivedAt int64) {


We're not returning all error conditions, maybe we should return them and in the caller log + ignore?

Which error conditions are you thinking of? This is in-line with emitAtlasError, unless you're talking about the caller.

Right yeah, it's indeed in line with emitAtlasError. Ok then let's keep it as-is

Copilot

Pull request overview

This PR adds Beholder event emission for Atlas user operation (userOp) data from the dualbroadcast MetaClient flow, enabling downstream observability of userOp hash + timing + lifecycle metadata.

Changes:

Add MetaMetrics.emitAtlasUserOp to emit pb.FastLaneAtlasUserOp to Beholder (including lifecycle ID and request/response timestamps).
Emit the userOp event from MetaClient.SendRequest for both success and JSON-RPC error responses (when a userOpHash is present).
Add a unit test validating the emitted protobuf payload for the userOp event.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
pkg/txm/clientwrappers/dualbroadcast/meta_metrics.go	Implements Beholder emission for `FastLaneAtlasUserOp` and adjusts Beholder emit logging for errors.
pkg/txm/clientwrappers/dualbroadcast/meta_client.go	Captures request/response timestamps and triggers userOp emission on both error and success responses.
pkg/txm/clientwrappers/dualbroadcast/meta_metrics_test.go	Adds a unit test for `emitAtlasUserOp` validating emitted protobuf fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-29T09:07:34Z

+
+	meta, err := tx.GetMeta()
+	if err != nil {
+		m.lggr.Errorw("Failed to get meta for tx. UserOpHash to emit was: "+userOpHash.Hex(), "txId", tx.ID, "err", err)


In the GetMeta() error path, the log message is built via string concatenation to include the userOpHash. For consistency with other structured logs (and to keep the message stable for log parsing), pass userOpHash as its own key/value field (e.g., "userOpHash", userOpHash.Hex()) instead of embedding it into the message string.

Suggested change

m.lggr.Errorw("Failed to get meta for tx. UserOpHash to emit was: "+userOpHash.Hex(), "txId", tx.ID, "err", err)

m.lggr.Errorw("Failed to get meta for tx", "txId", tx.ID, "userOpHash", userOpHash.Hex(), "err", err)

Copilot · 2026-04-29T09:07:35Z

 	})
 }
+
+func TestMetaClient_emitAtlasUserOp(t *testing.T) {


This test function name says "MetaClient" but it’s validating MetaMetrics.emitAtlasUserOp. Renaming it (e.g., to TestMetaMetrics_emitAtlasUserOp) would make failures easier to interpret and keep test naming accurate.

Suggested change

func TestMetaClient_emitAtlasUserOp(t *testing.T) {

func TestMetaMetrics_emitAtlasUserOp(t *testing.T) {

Copilot · 2026-04-29T09:07:35Z

+func (m *MetaMetrics) emitAtlasUserOp(ctx context.Context, userOpHash common.Hash, tx *types.Transaction, requestSentAt, responseReceivedAt int64) {
+	var nonce string
+	if tx.Nonce != nil {
+		nonce = strconv.FormatUint(*tx.Nonce, 10)
+	}
+
+	meta, err := tx.GetMeta()
+	if err != nil {
+		m.lggr.Errorw("Failed to get meta for tx. UserOpHash to emit was: "+userOpHash.Hex(), "txId", tx.ID, "err", err)
+		return
+	}


emitAtlasUserOp introduces multiple branches (nil nonce, nil/invalid meta, and emitter.Emit error handling) but the new tests only cover the fully-populated happy path. Adding coverage for the other branches (similar to the existing emitAtlasError tests) would help prevent regressions in these error-handling paths.

Emit beholder message for Atlas userOp

3a30336

dimriou force-pushed the oev-1266_userOp_data_submission branch from 2819694 to 3a30336 Compare April 24, 2026 15:55

Update chainlink-protos ref

2a3a953

dimriou force-pushed the oev-1266_userOp_data_submission branch from 8de2701 to 2a3a953 Compare April 27, 2026 08:30

cll-gg reviewed Apr 27, 2026

View reviewed changes

dimriou added 4 commits April 27, 2026 16:37

update Response structure

666b778

Address feedback

a6b7ebb

Merge branch 'develop' into oev-1266_userOp_data_submission

2f19931

Merge branch 'develop' into oev-1266_userOp_data_submission

df4fc35

dimriou marked this pull request as ready for review April 29, 2026 09:02

dimriou requested a review from a team as a code owner April 29, 2026 09:02

Copilot AI review requested due to automatic review settings April 29, 2026 09:02

dimriou requested a review from a team as a code owner April 29, 2026 09:02

dimriou enabled auto-merge (squash) April 29, 2026 09:02

product-security-plaid-production Bot requested review from RensR and yashnevatia April 29, 2026 09:02

Copilot started reviewing on behalf of dimriou April 29, 2026 09:03 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

cll-gg previously approved these changes Apr 29, 2026

View reviewed changes

Update log message

618932b

dimriou dismissed cll-gg’s stale review via 618932b April 29, 2026 10:26

cll-gg approved these changes Apr 29, 2026

View reviewed changes

yashnevatia approved these changes Apr 29, 2026

View reviewed changes

dimriou merged commit a6c5f73 into develop Apr 29, 2026
34 checks passed

dimriou deleted the oev-1266_userOp_data_submission branch April 29, 2026 10:55

cll-gg mentioned this pull request Apr 29, 2026

Several SVR + PLEX related improvements smartcontractkit/chainlink#22234

Merged

	m.lggr.Errorw("Failed to get meta for tx. UserOpHash to emit was: "+userOpHash.Hex(), "txId", tx.ID, "err", err)
	m.lggr.Errorw("Failed to get meta for tx", "txId", tx.ID, "userOpHash", userOpHash.Hex(), "err", err)

	func TestMetaClient_emitAtlasUserOp(t *testing.T) {
	func TestMetaMetrics_emitAtlasUserOp(t *testing.T) {

Conversation

dimriou commented Apr 24, 2026

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-evm

⚠️ Breaking Changes (1)

pkg/txm/clientwrappers/dualbroadcast.Response (1)

Uh oh!

cll-gg Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

dimriou Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

cll-gg Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

cll-gg Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

cll-gg Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

cll-gg Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

dimriou Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cll-gg Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Apr 24, 2026 •

edited

Loading

⚠️ API Diff Results - `github.com/smartcontractkit/chainlink-evm`

`pkg/txm/clientwrappers/dualbroadcast.Response` (1)

dimriou Apr 27, 2026 •

edited

Loading