rm slither#476
Merged
Merged
Conversation
Contributor
📊 API Diff Results
|
product-security-plaid-production
Bot
requested review from
RayXpub,
kdihalas and
skudasov
and removed request for
RayXpub
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Slither-related static analysis tooling from the contracts CI setup, including the LLM-based “new issues diff” generation, associated prompts/scripts/configs, and inline Slither suppression comments in a few Solidity files.
Changes:
- Removed the Slither static-analysis job (and its report/diff/comment plumbing) from
.github/workflows/solidity-foundry.yml. - Deleted Slither prompt files, diff script, and Slither config JSON files previously used by CI.
- Removed a few
slither-disable-next-line ...directives from Solidity contracts/mocks, and disabled Slither report generation in the artifacts workflow.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| contracts/src/v0.8/shared/token/ERC20/zksync/WETH9ZKSync.sol | Removes a Slither suppression comment for the low-level call used in withdraw. |
| contracts/src/v0.8/l2ep/test/mocks/MockOptimismL2CrossDomainMessenger.sol | Removes a Slither suppression comment on xDomainMessageSender(). |
| contracts/src/v0.8/l2ep/test/mocks/MockOptimismL1CrossDomainMessenger.sol | Removes Slither suppression comments on xDomainMessageSender() and relayMessage(...). |
| contracts/scripts/ci/prompt-validation.md | Deletes the Slither “new issues report” validation prompt. |
| contracts/scripts/ci/prompt-difference.md | Deletes the Slither report “new issues diff” prompt. |
| contracts/scripts/ci/find_slither_report_diff.sh | Deletes the script that called OpenAI to diff Slither reports. |
| contracts/configs/slither/.slither.config-default-pr.json | Deletes Slither config used for default PR scans. |
| contracts/configs/slither/.slither.config-ccip-pr.json | Deletes Slither config used for CCIP PR scans. |
| contracts/configs/slither/.slither.config-artifacts.json | Deletes Slither config used for artifact-generation scans. |
| .github/workflows/solidity-foundry.yml | Removes the dedicated Slither “analyze” job and associated documentation comments. |
| .github/workflows/solidity-foundry-artifacts.yml | Disables Slither report generation in the artifact-generation workflow invocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RayXpub
previously approved these changes
May 19, 2026
matYang
previously approved these changes
May 19, 2026
mohamed-mehany
previously approved these changes
May 20, 2026
RensR
dismissed stale reviews from mohamed-mehany, matYang, and RayXpub
via
e43c441
mohamed-mehany
approved these changes
May 20, 2026
RayXpub
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.