[RPC Metric Part 2] RPC Metrics Integration in Multinode#91
[RPC Metric Part 2] RPC Metrics Integration in Multinode#91
Conversation
…ency, RPC error rate
|
👋 guandali, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ad0b978a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| ) | ||
|
|
||
| replace github.com/smartcontractkit/chainlink-framework/metrics => ../metrics |
There was a problem hiding this comment.
Bump metrics module version instead of local replace
Adding replace github.com/smartcontractkit/chainlink-framework/metrics => ../metrics makes local tests pass, but consumers of github.com/smartcontractkit/chainlink-framework/multinode do not apply replace directives from dependency modules, so they will resolve the pinned required metrics version (v0.0.0-20250717121125-2350c82883e2) instead. That version does not contain the new metrics.RPCClientMetrics API used by multinode/rpc_client_base.go, causing downstream builds to fail once they import this commit.
Useful? React with 👍 / 👎.
Description
RPC Metrics Integration in Multinode
Summary
Wire optional RPC metrics into multinode so
LatestBlockandLatestFinalizedBlockreport latency and errors when a non-nilmetrics.RPCClientMetricsis provided.Changes
multinode/go.mod
replacedirective to use local metrics package:Requires Dependencies
First PR
Resolves Dependencies