Skip to content

[RPC Metric Part 2] RPC Metrics Integration in Multinode#91

Open
guandali wants to merge 11 commits intomainfrom
lli/rpc-metric2
Open

[RPC Metric Part 2] RPC Metrics Integration in Multinode#91
guandali wants to merge 11 commits intomainfrom
lli/rpc-metric2

Conversation

@guandali
Copy link
Member

@guandali guandali commented Mar 17, 2026

Description

RPC Metrics Integration in Multinode

Summary

Wire optional RPC metrics into multinode so LatestBlock and LatestFinalizedBlock report latency and errors when a non-nil metrics.RPCClientMetrics is provided.


Changes

multinode/go.mod

  • Updated replace directive to use local metrics package:

Requires Dependencies

First PR

Resolves Dependencies

@guandali guandali requested a review from a team as a code owner March 17, 2026 15:50
@github-actions
Copy link

👋 guandali, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@guandali guandali changed the title Lli/rpc metric2 RPC Metrics Integration in Multinode Mar 17, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ad0b978a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

gopkg.in/yaml.v3 v3.0.1 // indirect
)

replace github.com/smartcontractkit/chainlink-framework/metrics => ../metrics

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Bump metrics module version instead of local replace

Adding replace github.com/smartcontractkit/chainlink-framework/metrics => ../metrics makes local tests pass, but consumers of github.com/smartcontractkit/chainlink-framework/multinode do not apply replace directives from dependency modules, so they will resolve the pinned required metrics version (v0.0.0-20250717121125-2350c82883e2) instead. That version does not contain the new metrics.RPCClientMetrics API used by multinode/rpc_client_base.go, causing downstream builds to fail once they import this commit.

Useful? React with 👍 / 👎.

@guandali guandali changed the title RPC Metrics Integration in Multinode [RPC Metric Part 2] RPC Metrics Integration in Multinode Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant