Skip to content

add total number of capability participants to step data#202

Merged
EasterTheBunny merged 5 commits intomainfrom
CRE-1007/capability-don-metering-support
Oct 6, 2025
Merged

add total number of capability participants to step data#202
EasterTheBunny merged 5 commits intomainfrom
CRE-1007/capability-don-metering-support

Conversation

@EasterTheBunny
Copy link
Copy Markdown
Contributor

@EasterTheBunny EasterTheBunny commented Oct 1, 2025 •
edited by atlassian Bot
Loading

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 1, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 01f2996

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 1, 2025 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedOct 6, 2025, 3:31 PM

This was referenced Oct 1, 2025
Merged
Merged
@EasterTheBunny EasterTheBunny force-pushed the CRE-1007/capability-don-metering-support branch from 5987ffa to fa0edfa Compare October 1, 2025 15:50
@EasterTheBunny EasterTheBunny marked this pull request as ready for review October 1, 2025 16:00
@EasterTheBunny EasterTheBunny requested review from a team as code owners October 1, 2025 16:00
chudilka1
chudilka1 previously approved these changes Oct 6, 2025
View reviewed changes
jmank88
jmank88 previously approved these changes Oct 6, 2025
View reviewed changes
patrickhuie19
patrickhuie19 reviewed Oct 6, 2025
View reviewed changes
Comment thread workflows/workflows/v1/metering.proto Outdated
string agg_spend_value = 2;
string agg_spend_unit = 3;
string agg_spend_value_cre = 4;
uint32 n = 5; // n provides the total node count for capability DONs
Copy link
Copy Markdown
Contributor

@patrickhuie19 patrickhuie19 Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proto comments aren't discoverable in IDEs the same way go comments are - can we rename to something very obtuse like
CapDON_N?

@EasterTheBunny EasterTheBunny enabled auto-merge (squash) October 6, 2025 15:30
@EasterTheBunny EasterTheBunny merged commit 770c21c into main Oct 6, 2025
20 checks passed
@EasterTheBunny EasterTheBunny deleted the CRE-1007/capability-don-metering-support branch October 6, 2025 15:31
MStreet3 pushed a commit that referenced this pull request Oct 14, 2025
@EasterTheBunny @app-token-issuer-engops @MStreet3
add total number of capability participants to step data (#202)
eef7d9c 
* add total number of capability participants to step data

* bot: regenerate protobuf files

* rename n for better clarity

* bot: regenerate protobuf files

---------

Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@jmank88 jmank88 jmank88 left review comments

@chudilka1 chudilka1 chudilka1 left review comments

@ecPablo ecPablo Awaiting requested review from ecPablo

@Atrax1 Atrax1 Awaiting requested review from Atrax1

+1 more reviewer

@HouseOfHufflepuff HouseOfHufflepuff HouseOfHufflepuff left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@EasterTheBunny @HouseOfHufflepuff @jmank88 @patrickhuie19 @chudilka1