-
Notifications
You must be signed in to change notification settings - Fork 43
[TT-1722] WASP new docs as mdbook #1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
94745a9 to
b7eb38b
Compare
book/src/libs/wasp/configuration.md
Outdated
|
|
||
| At a minimum, you need to provide the following environment variables, as WASP requires Loki: | ||
|
|
||
| * `LOKI_TENANT_ID` - *(optional)* A tenant ID that acts as a bucket identifier for logs, logically separating them from other sets of logs. If the tenant ID doesn't exist, Loki will create it. Can be empty if log separation is not a concern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tofel probaby worth splitting to Required and Optional here? I see "Required" and immediately first var is optional :)
|
|
||
| // Define RPS schedule | ||
| rpsSchedule := wasp.Combine( | ||
| wasp.Steps(1, 1, 9, 10*time.Second), // Start with 1 RPS, increment by 1 RPS in 9 steps over 10 seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
named parameters would go a long way here
book/src/libs/wasp/k8s.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| # WASP - k8s | |||
|
|
|||
| TBD No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking that this is not lost in action
|
|
||
| ```go | ||
| epsilonSchedule := wasp.Combine( | ||
| wasp.Steps(1, 1, 4, 10*time.Second), // Start at 1 RPS, increment by 1 RPS in 4 steps over 10 seconds (1 increment every 2.5 seconds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Named params will help a lot here and below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AKhozya but I think that's out of scope for this PR. If we want named parameters we should change these methods to accept structs with named fields, no other way in go. If only it was Kotlin....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, cool - I thought they come for free - my kotlin and ruby past :P
wasp/Makefile
Outdated
| start: | ||
| docker compose -f compose/docker-compose.yaml up -d | ||
| sleep 5 && curl -X POST -H "Content-Type: application/json" -d '{"name":"test", "role": "Admin"}' http://localhost:3000/api/auth/keys | jq .key | ||
| sleep 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if this should be replaced with proper waiting, e.g. for log message or process up
|


Also:
Profile.Run()