Skip to content

Allow network configuration to be overridden/merged with existing config#152

Merged
skudasov merged 1 commit intomainfrom
chore/override_networks_config
Nov 26, 2021
Merged

Allow network configuration to be overridden/merged with existing config#152
skudasov merged 1 commit intomainfrom
chore/override_networks_config

Conversation

@jleeh
Copy link
Copy Markdown
Contributor

@jleeh jleeh commented Nov 25, 2021

For example:

NETWORK_SETTINGS=other-networks.yaml

When the above env var is set, it will result in the other-networks.yaml file to be deep merged into the networks.yaml file in the root of this repo.

@jleeh jleeh requested a review from skudasov November 25, 2021 16:58
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #152 (0084ef2) into main (5a3b2a0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   11.52%   11.52%           
=======================================
  Files          11       11           
  Lines        1380     1380           
=======================================
  Hits          159      159           
  Misses       1205     1205           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3b2a0...0084ef2. Read the comment docs.

@skudasov skudasov merged commit e2d5b9f into main Nov 26, 2021
@archseer archseer deleted the chore/override_networks_config branch December 14, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants