Skip to content

Conversation

@skudasov
Copy link
Contributor

@skudasov skudasov commented Feb 12, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes implement new functionality for configuring Solana blockchain components, adding support for overriding Solana test validator command parameters and introducing Grafana integration for annotations within the framework. These enhancements aim to provide more flexibility in blockchain simulations and improve monitoring capabilities through Grafana.

What

  • book/src/framework/components/blockchains/solana.md
    • Added documentation for a new configuration option docker_cmd_params to specify custom Docker command parameters for the Solana test validator.
  • framework/.changeset/v0.5.1.md
    • Created a new changeset file indicating the addition of overriding Solana test validator command parameters and unspecified additional changes.
  • framework/components/blockchain/solana.go
    • Modified newSolana function to include in.DockerCmdParamsOverrides in the arguments passed to the Solana test validator, allowing for custom command parameters.
  • framework/grafana/grafana.go
    • Added a new Grafana client with functionalities to get and post annotations, enabling integration with Grafana for monitoring and alerting purposes.
  • framework/grafana/grafana_test.go
    • Added integration tests for the Grafana client's PostAnnotation method to verify its functionality against a real Grafana instance.

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
53.5% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube

@skudasov skudasov marked this pull request as ready for review February 13, 2025 08:19
@skudasov skudasov requested a review from a team as a code owner February 13, 2025 08:19
@skudasov skudasov merged commit 84eb8e7 into main Feb 13, 2025
52 of 56 checks passed
@skudasov skudasov deleted the grafana-annotations branch February 13, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant