DevBox migration, unified lint, unified test and simplified CI #1670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skudasov
force-pushed
the
devbox
branch
21 times, most recently
from
7b43a77 to
8d72bda
Compare
|
skudasov
force-pushed
the
devbox
branch
2 times, most recently
from
f439b77 to
b80f7fc
Compare
skudasov
changed the title
skudasov
force-pushed
the
devbox
branch
2 times, most recently
from
57cb39a to
4f071df
Compare
erikburt
approved these changes
Mar 10, 2025
# Conflicts: # framework/cmd/ci.go
gheorghestrimtu
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
.githooksand.github/workflowsdirectories. The primary focus is on removing various pre-commit hooks and GitHub Actions workflows, simplifying the repository's setup and maintenance.Removal of Pre-commit Hooks:
.githooks/detect-ethereum-keys: Removed script that checks for Ethereum keys in files before committing..githooks/detect-rpc-urls: Removed script that checks for RPC URLs in files before committing..githooks/go-mod-local-replace: Removed script that checks for local replacements ingo.modfiles before committing..githooks/run-unit-tests: Removed script that runs unit tests before committing.Updates to Existing Scripts:
.githooks/go-lint: Simplified the linting process by replacing the existing script with a singledevbox run lintcommand..githooks/go-test-build: Updated the script to exclude the 'seth' directory from thego testcommand due to environment variable requirements.Removal of GitHub Actions Workflows:
.github/workflows/framework.yml: Removed the workflow for running framework Docker component tests..github/workflows/generate-go-docs.yaml: Removed the workflow for generating Go documentation on labeled pull requests..github/workflows/k8s-e2e.yaml: Removed the workflow for running end-to-end tests on Kubernetes packages.