Skip to content

fix CI template#2366

Merged
skudasov merged 2 commits intomainfrom
gen-ci
Jan 28, 2026
Merged

fix CI template#2366
skudasov merged 2 commits intomainfrom
gen-ci

Conversation

@skudasov
Copy link
Contributor

@skudasov skudasov commented Jan 28, 2026


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes introduce a new CI share action for AWS ECR authentication and fix a typo in the JD_IMAGE environment variable assignment within the GitHub Actions workflows. The addition of the CI share action enhances the automation for AWS ECR authentication across different workflows, making it reusable and maintaining consistency. The typo fix ensures the JD_IMAGE variable is correctly set for the environment.

What

  • framework/.changeset/v0.13.12.md
    • Added a new changeset document noting the addition of CI share action for ECR Auth. This documents the change for release notes.
  • framework/tmpl_gen_env.go
    • Fixed a typo in the JD_IMAGE environment variable assignment from ${{ secrets.JD_IMAGE $}} to ${{ secrets.JD_IMAGE }}. This correction ensures the environment variable is properly parsed and used in GitHub Actions workflows.
    • Added a new template CIECRAuthActionTmpl for configuring AWS credentials and authenticating to ECR Public. This template includes inputs for role-to-assume, aws-region, registry-type, and registries, along with steps to configure AWS credentials and authenticate to ECR. This addition facilitates reusability and standardization for AWS ECR authentication in CI workflows.

@skudasov skudasov requested a review from a team as a code owner January 28, 2026 20:57
@github-actions
Copy link

👋 skudasov, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@skudasov skudasov enabled auto-merge (squash) January 28, 2026 21:01
@skudasov skudasov merged commit f05db70 into main Jan 28, 2026
74 of 76 checks passed
@skudasov skudasov deleted the gen-ci branch January 28, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants