Skip to content

[DX-3791] scan docker logs for panics#2520

Merged
Tofel merged 8 commits intomainfrom
dx-3791-scan-for-docker-panics
Apr 15, 2026
Merged

[DX-3791] scan docker logs for panics#2520
Tofel merged 8 commits intomainfrom
dx-3791-scan-for-docker-panics

Conversation

@Tofel
Copy link
Copy Markdown
Contributor

@Tofel Tofel commented Apr 15, 2026

Changes:

  • scan docker logs for panics
  • add docker log stream fanout, so that we don't need to read log stream multiple times in each log-consuming function

…m multiple times in each log-consuming function
@Tofel Tofel requested a review from a team as a code owner April 15, 2026 08:55
Copilot AI review requested due to automatic review settings April 15, 2026 08:55
@github-actions
Copy link
Copy Markdown

👋 Tofel, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the framework Docker log utilities to support reusing a single container log stream across multiple consumers (fanout), and adds helpers/tests for saving and printing container logs (including red-colored output).

Changes:

  • Introduces Docker log stream fanout (StreamContainerLogsFanout / fanoutContainerLogs) so multiple consumers can process the same underlying container log stream.
  • Refactors log saving into SaveContainerLogsFromStreams and adds PrintFailedContainerLogs(FromStreams) for printing exited/dead container log tails.
  • Adds RedText ANSI helper and unit tests covering fanout + the new stream-based save/print helpers.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
framework/docker.go Adds fanout streaming, refactors log saving to accept pre-fetched streams, and introduces printing of failed container logs.
framework/docker_fanout_test.go Adds tests for fanout replication and the new stream-based save/print helpers.
framework/text.go Adds RedText helper for ANSI red terminal output used when printing failed logs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread framework/docker.go Outdated
Comment thread framework/docker.go Outdated
Comment thread framework/docker.go Outdated
Comment thread framework/docker.go Outdated
Comment thread framework/docker.go Outdated
Comment thread framework/docker_fanout_test.go
@Tofel Tofel force-pushed the dx-3791-scan-for-docker-panics branch from 5abd0dd to 62e3604 Compare April 15, 2026 12:58
@Tofel Tofel force-pushed the dx-3791-scan-for-docker-panics branch from 62e3604 to 3c909c2 Compare April 15, 2026 12:58
skudasov
skudasov previously approved these changes Apr 15, 2026
@Tofel Tofel merged commit 2551105 into main Apr 15, 2026
84 of 87 checks passed
@Tofel Tofel deleted the dx-3791-scan-for-docker-panics branch April 15, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants