Merged
Conversation
…m multiple times in each log-consuming function
|
👋 Tofel, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the framework Docker log utilities to support reusing a single container log stream across multiple consumers (fanout), and adds helpers/tests for saving and printing container logs (including red-colored output).
Changes:
- Introduces Docker log stream fanout (
StreamContainerLogsFanout/fanoutContainerLogs) so multiple consumers can process the same underlying container log stream. - Refactors log saving into
SaveContainerLogsFromStreamsand addsPrintFailedContainerLogs(FromStreams)for printing exited/dead container log tails. - Adds
RedTextANSI helper and unit tests covering fanout + the new stream-based save/print helpers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
framework/docker.go |
Adds fanout streaming, refactors log saving to accept pre-fetched streams, and introduces printing of failed container logs. |
framework/docker_fanout_test.go |
Adds tests for fanout replication and the new stream-based save/print helpers. |
framework/text.go |
Adds RedText helper for ANSI red terminal output used when printing failed logs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
743a6a3 to
c2e9f2e
Compare
4 tasks
5abd0dd to
62e3604
Compare
62e3604 to
3c909c2
Compare
skudasov
previously approved these changes
Apr 15, 2026
skudasov
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: