Skip to content

[DX-4090] allow to cut off latest tags by ceiling version#2565

Merged
Tofel merged 1 commit intomainfrom
dx-4049-compat-tool-tag-ceiling
May 6, 2026
Merged

[DX-4090] allow to cut off latest tags by ceiling version#2565
Tofel merged 1 commit intomainfrom
dx-4049-compat-tool-tag-ceiling

Conversation

@Tofel
Copy link
Copy Markdown
Contributor

@Tofel Tofel commented May 6, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 6, 2026 14:08
@Tofel Tofel requested a review from a team as a code owner May 6, 2026 14:08
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

👋 Tofel, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for limiting the automatically selected SemVer tag upgrade/rollback sequence by an optional “ceiling” version, primarily for the compat CLI flow.

Changes:

  • Extend FilterSemverTags / FindSemVerRefSequence to accept an optional tagVersionCeiling and filter out tags above it.
  • Add CLI flag plumbing intended to pass the ceiling value into the upgrade-sequence selection.
  • Add unit tests covering ceiling behavior, and a changeset entry documenting the feature.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
framework/compat.go Adds ceiling-based filtering to SemVer tag selection and threads the new parameter through helpers.
framework/compat_test.go Adds test cases to validate the ceiling behavior (including with include/exclude).
framework/cmd/main.go Introduces a new CLI flag intended to supply the ceiling version for automatic tag selection.
framework/.changeset/v0.15.21.md Documents the new optional ceiling feature for the compat command.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread framework/cmd/main.go Outdated
Comment thread framework/compat.go
@Tofel Tofel force-pushed the dx-4049-compat-tool-tag-ceiling branch from bfccb1b to 1ee0c63 Compare May 6, 2026 14:15
@Tofel Tofel enabled auto-merge (squash) May 6, 2026 14:18
@Tofel Tofel merged commit 9244d8d into main May 6, 2026
76 of 78 checks passed
@Tofel Tofel deleted the dx-4049-compat-tool-tag-ceiling branch May 6, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants