[DX-4090] allow to cut off latest tags by ceiling version#2565
Merged
Conversation
|
👋 Tofel, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for limiting the automatically selected SemVer tag upgrade/rollback sequence by an optional “ceiling” version, primarily for the compat CLI flow.
Changes:
- Extend
FilterSemverTags/FindSemVerRefSequenceto accept an optionaltagVersionCeilingand filter out tags above it. - Add CLI flag plumbing intended to pass the ceiling value into the upgrade-sequence selection.
- Add unit tests covering ceiling behavior, and a changeset entry documenting the feature.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
framework/compat.go |
Adds ceiling-based filtering to SemVer tag selection and threads the new parameter through helpers. |
framework/compat_test.go |
Adds test cases to validate the ceiling behavior (including with include/exclude). |
framework/cmd/main.go |
Introduces a new CLI flag intended to supply the ceiling version for automatic tag selection. |
framework/.changeset/v0.15.21.md |
Documents the new optional ceiling feature for the compat command. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bfccb1b to
1ee0c63
Compare
skudasov
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.