Skip to content

support dynamic host port allocation for ChIP Config container#2589

Merged
Tofel merged 3 commits into
mainfrom
dynamic-host-port-chip-config
May 12, 2026
Merged

support dynamic host port allocation for ChIP Config container#2589
Tofel merged 3 commits into
mainfrom
dynamic-host-port-chip-config

Conversation

@Tofel
Copy link
Copy Markdown
Contributor

@Tofel Tofel commented May 12, 2026

Found one more startup failure in CI:

Error: failed to start Beholder: failed to create Chip Ingress set: failed to start stack for Chip Ingress: compose up: 
Error response from daemon: failed to set up container networking: driver failed programming external connectivity on endpoint chip-config (a07750e18994ea2174e2bf4d2b3e85d8b2b3379852ab626d72f8c42b4d495279): 
failed to bind host port for 0.0.0.0:50052:172.19.0.5:50051/tcp: address already in use

Copilot AI review requested due to automatic review settings May 12, 2026 07:34
@Tofel Tofel requested a review from a team as a code owner May 12, 2026 07:34
@github-actions
Copy link
Copy Markdown

👋 Tofel, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses CI flakiness caused by host-port collisions when starting the Chip Config container by switching the compose port mapping to dynamic host port allocation and updating the Go component to report the actual mapped external port.

Changes:

  • Updated chip-config Docker Compose port mapping to use an ephemeral host port by default.
  • Updated chip_ingress_set startup code to derive Chip Config’s external gRPC URL from either an env var override or the container’s mapped port.
  • Added a dockercompose component changeset entry describing the change.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
framework/components/dockercompose/chip_ingress_set/docker-compose.yml Switch chip-config host port mapping from fixed 50052 to dynamic allocation via env/default.
framework/components/dockercompose/chip_ingress_set/chip_ingress.go Compute Chip Config external gRPC URL using mapped host port (or env override).
framework/components/dockercompose/.changeset/v0.1.23.md Record the behavioral change in the component changeset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread framework/components/dockercompose/chip_ingress_set/docker-compose.yml Outdated
Comment thread framework/components/dockercompose/chip_ingress_set/chip_ingress.go Outdated
Comment thread framework/components/dockercompose/chip_ingress_set/chip_ingress.go
@Tofel Tofel enabled auto-merge (squash) May 12, 2026 08:43
@Tofel Tofel merged commit 1845067 into main May 12, 2026
77 checks passed
@Tofel Tofel deleted the dynamic-host-port-chip-config branch May 12, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants