support dynamic host port allocation for ChIP Config container#2589
Conversation
|
👋 Tofel, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
This PR addresses CI flakiness caused by host-port collisions when starting the Chip Config container by switching the compose port mapping to dynamic host port allocation and updating the Go component to report the actual mapped external port.
Changes:
- Updated
chip-configDocker Compose port mapping to use an ephemeral host port by default. - Updated
chip_ingress_setstartup code to derive Chip Config’s external gRPC URL from either an env var override or the container’s mapped port. - Added a dockercompose component changeset entry describing the change.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| framework/components/dockercompose/chip_ingress_set/docker-compose.yml | Switch chip-config host port mapping from fixed 50052 to dynamic allocation via env/default. |
| framework/components/dockercompose/chip_ingress_set/chip_ingress.go | Compute Chip Config external gRPC URL using mapped host port (or env override). |
| framework/components/dockercompose/.changeset/v0.1.23.md | Record the behavioral change in the component changeset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Found one more startup failure in CI: